Review Request 112044: Fixes: 322220 - Wikipedia applet shouldn't reload content if the artist/album hasn't changed

[Mark Kretschmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112044/#review37645
-----------------------------------------------------------

Ship it!


Well spotted! I was wondering about this one.

- Mark Kretschmann


On Aug. 13, 2013, 6:41 a.m., Frank Meerkoetter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112044/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2013, 6:41 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> This patch (hopefully) fixes 322220.
> 
> This (cut&paste?) error undermined the function of _checkRequireUpdate() if the artist and the composer are different for a track.
> 
> 
> Diffs
> -----
> 
>   src/context/engines/wikipedia/WikipediaEngine.cpp 0b75f15 
> 
> Diff: http://git.reviewboard.kde.org/r/112044/diff/
> 
> 
> Testing
> -------
> 
> I have tested with several mp3s where artist and composer are different, i also tested with mp3s where they are the same. No unnecessary reloading for the artist page was observerd. 
> 
> 
> Thanks,
> 
> Frank Meerkoetter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130813/1c0fa395/attachment.html>