Review Request 110187: Don't communicate with mysql by env vars and autogenerated files

[Edward Hades Toroshchin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110187/#review31732
-----------------------------------------------------------


Just tested it on my box and it doesn't work:

amarok:             ^[[07;31m[ERROR__]^[[00;39m MySQL library initialization failed.
amarok:             ^[[07;31m[ERROR__]^[[00;39m [MySqlStorage] "GREPME MySQLe query failed! (2000) mysql_embedded: Shutdown complete on init"



src/core-impl/collections/db/sql/mysqlecollection/MySqlEmbeddedStorage.cpp
<http://git.reviewboard.kde.org/r/110187/#comment23647>

    This can only end well.
    
    I would rather avoid magic numbers, and construct the pointer array dynamically, say QVector<char*> or similar.
    
    Mat?j, what do you think?



src/core-impl/collections/db/sql/mysqlecollection/MySqlEmbeddedStorage.cpp
<http://git.reviewboard.kde.org/r/110187/#comment23648>

    I don't think this is correct way of formatting for() (spaces before semicolons are superfluous.



src/core-impl/collections/db/sql/mysqlecollection/MySqlEmbeddedStorage.cpp
<http://git.reviewboard.kde.org/r/110187/#comment23646>

    whitespace error


- Edward Hades Toroshchin


On April 25, 2013, 2:36 p.m., Patrick von Reth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110187/
> -----------------------------------------------------------
> 
> (Updated April 25, 2013, 2:36 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Don't communicate with mysql by env vars and autogenerated files
> 
> Instead of generating the my.cnf every time amarok starts and to pass
> the location of this file by setting an environment variable directly
> pass the settings as arguments to mysql. As this is probably a better
> approach and the only one working on windows.
> 
> This fixes an issue where amarok is writing the database to "C:\Program Files (x86)\Amarok\data\amarok".
> This issue prevents Amarok from running correctly, because regarding to the rights of the useraccount the directory can be not writeable.
> 
> The commands used are taken from the output of "mysqld --verbose --help". 
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/db/sql/mysqlecollection/MySqlEmbeddedStorage.cpp 0233498fdeb18ab51e709e9a78384fc37c47cb2a 
> 
> Diff: http://git.reviewboard.kde.org/r/110187/diff/
> 
> 
> Testing
> -------
> 
> Only on windows
> 
> 
> Thanks,
> 
> Patrick von Reth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130429/54369676/attachment-0001.html>