Review Request 110150: Feedback when transcoding during ripping an Audio CD fails

[Tatjana Gornak]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110150/#review31713
-----------------------------------------------------------



src/core-impl/collections/audiocd/FormatSelectionDialog.cpp
<http://git.reviewboard.kde.org/r/110150/#comment23626>

    Note: you can test if changes introduce whitespace errors with  git diff --check


- Tatjana Gornak


On April 27, 2013, 2:17 p.m., Abhinandan Ramaprasath wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110150/
> -----------------------------------------------------------
> 
> (Updated April 27, 2013, 2:17 p.m.)
> 
> 
> Review request for Amarok and Tatjana Gornak.
> 
> 
> Description
> -------
> 
> Informs the user if a codec is installed or not by displaying "<CODEC> codec not installed" in the description of the format during format selection.
> 
> 
> This addresses bug 311329.
>     https://bugs.kde.org/show_bug.cgi?id=311329
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/audiocd/FormatSelectionDialog.h 0d353ef 
>   src/core-impl/collections/audiocd/FormatSelectionDialog.cpp 7ae2563 
> 
> Diff: http://git.reviewboard.kde.org/r/110150/diff/
> 
> 
> Testing
> -------
> 
> Tested for mp3,ogg and flac.
> 
> 
> Thanks,
> 
> Abhinandan Ramaprasath
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130428/42b40b4e/attachment.html>