Review Request 110139: Small bugfixes. Fixes clang warnings.

Konrad Zemek konrad.zemek at gmail.com
Sat Apr 27 22:11:43 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110139/
-----------------------------------------------------------

(Updated April 27, 2013, 10:11 p.m.)


Review request for Amarok.


Changes
-------

Changed sizeof arguments and explicitly listed unused enums in switch statements


Description (updated)
-------

Small bugfixes. Fixes clang warnings.

A few legitimate, non critical bugs. Also minor changes to explicitly cover all enums in switch statements.


Diffs (updated)
-----

  src/browsers/playlistbrowser/PlaylistBrowserView.cpp fc7fe14a10ae0f4b25f9b0e0ccb85c246b82313d 
  src/core-impl/collections/daap/daapreader/authentication/md5.c 089118ff8bcd20aecade257c31d56a0447fc04de 
  src/core-impl/collections/db/sql/SqlQueryMaker.cpp fc5f6df29d9e22a97712a31b2aa71bc0e6424b40 
  src/core-impl/collections/upnpcollection/UpnpQueryMaker.cpp 93e068124beae4ba4f294e476d696cc0196dd298 
  src/dialogs/EditFilterDialog.cpp ac26497dcc5e5cf7cb9e2ea1a821dbce83276d34 

Diff: http://git.reviewboard.kde.org/r/110139/diff/


Testing
-------

Changed lines no longer generate warnings.


Thanks,

Konrad Zemek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130427/95aab5bb/attachment.html>


More information about the Amarok-devel mailing list