Review Request 110150: Feedback when transcoding fails

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110150/#review31681
-----------------------------------------------------------



src/core-impl/collections/audiocd/FormatSelectionDialog.h
<http://git.reviewboard.kde.org/r/110150/#comment23596>

    In header files, we try to include only things that are absolutely necessary and not replaceable by forward-declarations. This include is not necessary at all.



src/core-impl/collections/audiocd/FormatSelectionDialog.cpp
<http://git.reviewboard.kde.org/r/110150/#comment23597>

    Unfortunately, our "transcode when ripping a CD" code currently doesn't use the Amarok Transcoding framework, so checking the availability using that framework is actually incorrect.
    
    The current AudioCD code uses transcoding as offered by the kio-audiocd. Please check how to test availability of formats when kio-audiocd is used - perhaps the virtual directories don't exist? Test is yourself or contact kio-audiocd maintainer.
    
    On the other hand, AudioCD collection is slated for rewrite during this GSoC, you may ask Tatjana Gornak (who may have a chance to do it during GSoC) to make sure this patch would be useful even in future.
    
    Sorry if this bug shows not to be entirely junior.


- Matěj Laitl


On April 27, 2013, 2:15 p.m., Abhinandan Ramaprasath wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110150/
> -----------------------------------------------------------
> 
> (Updated April 27, 2013, 2:15 p.m.)
> 
> 
> Review request for Amarok and Tatjana Gornak.
> 
> 
> Description
> -------
> 
> Informs the user if a codec is installed or not by displaying "<CODEC> codec not installed" in the description of the format during format selection.
> 
> 
> This addresses bug 311329.
>     https://bugs.kde.org/show_bug.cgi?id=311329
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/audiocd/FormatSelectionDialog.h 0d353ef 
>   src/core-impl/collections/audiocd/FormatSelectionDialog.cpp 7ae2563 
> 
> Diff: http://git.reviewboard.kde.org/r/110150/diff/
> 
> 
> Testing
> -------
> 
> Tested for mp3,ogg and flac.
> 
> 
> Thanks,
> 
> Abhinandan Ramaprasath
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130427/149b8451/attachment-0001.html>