Review Request 110082: fixes Bug 275821 - JJ: Proper tooltips for Saved Playlists; remove Playlist::description() method

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110082/#review31671
-----------------------------------------------------------


Looks well, however the update mechanism needs to be tweaked - which is largely my fault.


src/core-impl/collections/db/sql/DatabaseUpdater.h
<http://git.reviewboard.kde.org/r/110082/#comment23586>

    Oh, I've misguided you, it seems that updates to playlist tables should be done in SqlUserPlaylistProvider instead (and it has its own database version etc), although it currently lacks the update mechanism - but you should be able to craft one. ;)


- Matěj Laitl


On April 22, 2013, 5:38 p.m., Vedant Agarwala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110082/
> -----------------------------------------------------------
> 
> (Updated April 22, 2013, 5:38 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> As agreed on the review for https://git.reviewboard.kde.org/r/104048/ , Qt::TooltipRole has been updated so that now the tooltip displays full name of the playlist. Occurrences of "description" have been removed (from the Playlist base class as well as the subclasses).
> 
> 
> This addresses bug 275821.
>     https://bugs.kde.org/show_bug.cgi?id=275821
> 
> 
> Diffs
> -----
> 
>   src/browsers/playlistbrowser/PlaylistBrowserModel.cpp 6ee3db3 
>   src/core-impl/collections/db/sql/DatabaseUpdater.h a7afbc9 
>   src/core-impl/collections/db/sql/DatabaseUpdater.cpp 2db6d98 
>   src/core-impl/collections/mediadevicecollection/playlist/MediaDevicePlaylist.h 9b94872 
>   src/core-impl/collections/mediadevicecollection/playlist/MediaDevicePlaylist.cpp 3510481 
>   src/core-impl/playlists/types/file/PlaylistFile.h 0358196 
>   src/core-impl/playlists/types/file/PlaylistFile.cpp 073e140 
>   src/core/playlists/Playlist.h cf9a4c0 
>   src/playlistmanager/SyncedPlaylist.h 214bb5c 
>   src/playlistmanager/SyncedPlaylist.cpp 56be7e8 
>   src/playlistmanager/sql/SqlPlaylist.h d28d161 
>   src/playlistmanager/sql/SqlPlaylist.cpp 2d6ef61 
>   src/playlistmanager/sql/SqlPlaylistGroup.cpp 2862034 
>   src/playlistmanager/sql/SqlUserPlaylistProvider.cpp 0ffb3d6 
> 
> Diff: http://git.reviewboard.kde.org/r/110082/diff/
> 
> 
> Testing
> -------
> 
> Testing done. Works. Builds successfully and passes the tests.
> 
> 
> File Attachments
> ----------------
> 
> displays the new tooltip
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/amarok_screenshot1.png
> displays the new tooltip
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/amarok_screenshot.png
> 
> 
> Thanks,
> 
> Vedant Agarwala
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130427/8d06541d/attachment-0001.html>