Review Request 110101: fixes Bug 242256 - JJ: Make Magnatue service use KWallet for password storage

Stefan Derkits stefan at derkits.at
Sat Apr 27 10:22:03 UTC 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

On 04/27/2013 11:45 AM, Vedant Agarwala wrote:
> I agree. I will upload another patch making changes to both last.fm
> and magnatune code. I was thinking of a common helper class
> complete with the "no KWallet found dialog". Tell me any other
> specifics that should be a part of this KWalletHelper class.

a common KWallet Helper Class (if possible) sounds good, the
GpodderService uses KWallet code that at the time of the creation of
the code was more or less a copy of the last.fm Wallet Code. So maybe
the GpodderService could also be a Candidate for using this
KWalletHelper class ;)

Greetings,
Stefan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEARECAAYFAlF7pssACgkQlZvAMV/NgGLEkQCgoai1Bi/PzZ4H6P1iNPQ4q42X
b3wAn1SsfeE/9ipouiiVLBtNFB9WDzUg
=5o1m
-----END PGP SIGNATURE-----


More information about the Amarok-devel mailing list