Review Request 110139: Small bugfixes. Fixes clang warnings.

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110139/#review31543
-----------------------------------------------------------


Nice cleanups, I agree with Edward's comments plus I have one more:


src/core-impl/collections/daap/daapreader/authentication/md5.c
<http://git.reviewboard.kde.org/r/110139/#comment23496>

    Nice catch. Wouldn't be sizeof(*ctx) more future-proof? (think of changes of the ctx type)


- Matěj Laitl


On April 24, 2013, 12:25 a.m., Konrad Zemek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110139/
> -----------------------------------------------------------
> 
> (Updated April 24, 2013, 12:25 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Small bugfixes. Fixes clang warnings.
> 
> A few legitimate, non critical bugs. Other changes are adding default case for enum switches where we're sure that all relevant cases have been covered.
> 
> 
> Diffs
> -----
> 
>   src/browsers/playlistbrowser/PlaylistBrowserView.cpp fc7fe14a10ae0f4b25f9b0e0ccb85c246b82313d 
>   src/core-impl/collections/daap/daapreader/authentication/md5.c 089118ff8bcd20aecade257c31d56a0447fc04de 
>   src/core-impl/collections/db/sql/SqlQueryMaker.cpp fc5f6df29d9e22a97712a31b2aa71bc0e6424b40 
>   src/core-impl/collections/upnpcollection/UpnpQueryMaker.cpp 93e068124beae4ba4f294e476d696cc0196dd298 
>   src/dialogs/EditFilterDialog.cpp ac26497dcc5e5cf7cb9e2ea1a821dbce83276d34 
> 
> Diff: http://git.reviewboard.kde.org/r/110139/diff/
> 
> 
> Testing
> -------
> 
> Changed lines no longer generate warnings.
> 
> 
> Thanks,
> 
> Konrad Zemek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130425/58383eb2/attachment-0001.html>