Review Request 109781: Bug #312407 - don't transcode from mp3 to mp3

[Matěj Laitl]

> On April 14, 2013, 2:53 p.m., Matěj Laitl wrote:
> > Good direction, although please see suggestions below to make the patch perfect. Also please adapt Transcoding::SelectConfigWidget::fillInChoices() to cope with new Transcoding::Configuration::prettyName() semantics and to show also all other TrackSelection choices for given encoder and parameters.
> 
> Anmol Ahuja wrote:
>     I can't seem to be able to mark those issues on the screenshot as fixed, or even comment on them!
> 
> Anmol Ahuja wrote:
>     "Also please adapt Transcoding::SelectConfigWidget::fillInChoices() to cope with new Transcoding::Configuration::prettyName() semantics and to show also all other TrackSelection choices for given encoder and parameters."
>     Oh, I seemed to have missed these.
>     I'll update the patch

> I can't seem to be able to mark those issues on the screenshot as fixed, or even comment on them!

Oh I see, it looks like a reviewboard bug. I'll count these as fixed. Moreover, I seem not to be able to "drop" the last in-code issue.


> On April 14, 2013, 2:53 p.m., Matěj Laitl wrote:
> > src/core/collections/CollectionLocation.cpp, lines 338-345
> > <http://git.reviewboard.kde.org/r/109781/diff/6/?file=132067#file132067line338>
> >
> >     I think that just removing the configuration.isValid() from the condition would have exactly the same effect, wouldn't it?
> 
> Anmol Ahuja wrote:
>     Then it'll end up saving the default value of TranscodeAll trackSelection value if the user hit cancel, overwriting the previous one. Would that be okay? I haven't changed this yet.

Oh I see, so keep it as it is.


- Matěj


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109781/#review30949
-----------------------------------------------------------


On April 19, 2013, 8:17 a.m., Anmol Ahuja wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109781/
> -----------------------------------------------------------
> 
> (Updated April 19, 2013, 8:17 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Added 3 checkbox in the TranscodingAssistantDialog:
> "Transcode all tracks" - transcode all tracks, the current default behavior
> "Ignore files which're already the selected format" - transcode only if source and destination file formats are different
> "Transcode only when needed for playability" - transcode only when needed for playability in the destination collection
> 
> 
> Diffs
> -----
> 
>   ChangeLog cc8b166 
>   src/core-impl/collections/db/sql/SqlCollectionLocation.cpp 8bc4552 
>   src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.h 3c2d9f2 
>   src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.cpp 8a40c6c 
>   src/core-impl/collections/support/CollectionLocationDelegateImpl.h b59beec 
>   src/core-impl/collections/support/CollectionLocationDelegateImpl.cpp f19cd9d 
>   src/core-impl/collections/umscollection/UmsCollectionLocation.h 45ba596 
>   src/core-impl/collections/umscollection/UmsCollectionLocation.cpp 2a30c9f 
>   src/core/collections/CollectionLocation.cpp 08f6910 
>   src/core/collections/CollectionLocationDelegate.h 6316d6f 
>   src/core/transcoding/TranscodingConfiguration.h 98b2bb8 
>   src/core/transcoding/TranscodingConfiguration.cpp f97a43d 
>   src/transcoding/TranscodingAssistantDialog.h 76287a7 
>   src/transcoding/TranscodingAssistantDialog.cpp 8348b12 
>   src/transcoding/TranscodingAssistantDialog.ui 2505bd3 
>   src/transcoding/TranscodingOptionsStackedWidget.h 9495d44 
>   src/transcoding/TranscodingOptionsStackedWidget.cpp cf4f328 
>   src/transcoding/TranscodingSelectConfigWidget.h aa5f196 
>   src/transcoding/TranscodingSelectConfigWidget.cpp adb593c 
>   tests/core/collections/MockCollectionLocationDelegate.h 5efbe2e7 
> 
> Diff: http://git.reviewboard.kde.org/r/109781/diff/
> 
> 
> Testing
> -------
> 
> Works as expected
> All build tests passed
> 
> 
> File Attachments
> ----------------
> 
> TranscodingAssistantDialog
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/04/18/TranscodingAssistantDialog_1.png
> 
> 
> Thanks,
> 
> Anmol Ahuja
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130419/3a3e6902/attachment.html>