Review Request 110081: Launching amarok with --cdplay adds CD in playlist

[Tatjana Gornak]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110081/
-----------------------------------------------------------

Review request for Amarok.


Description
-------

Main problem was that adding CD to playlist was connected to signal collectionReady, but this signal emits before collection becomes available in CollectionManager::instance()->viewableCollections(). So I changed collectionReady to collectionAdded signal from CollectionManager (since CollectionManager is responsible for adding new collection to a store). 

My concern is that collectionAdded emits only if some conditions are fulfilled. It seems to me that they are always fulfilled in considered case, but I'm not sure.


This addresses bug 279188.
    https://bugs.kde.org/show_bug.cgi?id=279188


Diffs
-----

  src/core-impl/collections/audiocd/AudioCdCollection.cpp 3dfa7c3 
  ChangeLog cc8b166 
  src/MainWindow.cpp 4273d8a 

Diff: http://git.reviewboard.kde.org/r/110081/diff/


Testing
-------

Launching amarok with --cdplay adds CD in playlist


Thanks,

Tatjana Gornak

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130419/ace43d9f/attachment.html>