Review Request 110070: Refactored playlist multilevel sorting algorithm.

Konrad Zemek konrad.zemek at gmail.com
Wed Apr 17 23:45:11 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110070/
-----------------------------------------------------------

Review request for Amarok.


Description
-------

Refactored playlist multilevel sorting algorithm.

BUGFIX:
	Wrong album is played if 2 albums with same title but different artist

BUG: 271105


This addresses bug 271105.
    https://bugs.kde.org/show_bug.cgi?id=271105


Diffs
-----

  src/playlist/proxymodels/SortAlgorithms.cpp c7d0df9f6b86318fd896a6de08fef6d85623215b 
  src/playlist/proxymodels/SortScheme.h 0fcd3a580deff7f2b4e6e65d0551c7332e0b6c9e 
  src/playlist/proxymodels/SortScheme.cpp de4f37adaeb6e8bb914eb7c91ff4803d01fc5623 
  tests/playlist/TestPlaylistModels.cpp 8964333517e431487b6ad4ba50d3e359f51bf3f6 

Diff: http://git.reviewboard.kde.org/r/110070/diff/


Testing
-------

Manual tests + relevant unittest added in testplaylistmodels


Thanks,

Konrad Zemek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130417/4936d2ef/attachment.html>


More information about the Amarok-devel mailing list