Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

[Harsh Gupta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108995/
-----------------------------------------------------------

(Updated April 13, 2013, 9:44 p.m.)


Review request for Amarok.


Changes
-------

Second patch :  Bug fixed.


Description
-------

1. Disabled Pre-amplifier in equalizer if it is not supported by phonon.
2. Fixed top and bottom labels of first slider. Earlier band name label was at the top and slider value label was at the bottom for first slider.
3. Removed an extra semicolon EqualizerDialog.h .
Note : I have made an assumption that if at all preamp is present then it will the first element of Effect Parameter list.


This addresses bug 301311.
    https://bugs.kde.org/show_bug.cgi?id=301311


Diffs (updated)
-----

  ChangeLog a278be3 
  src/EngineController.h 5de4beb 
  src/EngineController.cpp 28fb256 
  src/dialogs/EqualizerDialog.cpp f42a033 
  src/dialogs/EqualizerDialog.ui 43b0187 

Diff: http://git.reviewboard.kde.org/r/108995/diff/


Testing
-------

All unit test cases passed.
Note : I have tested it with gstreamer only. Xine phonon keep crashing on my PC.


File Attachments
----------------

Equalizer snapshot
  http://git.reviewboard.kde.org/media/uploaded/files/2013/02/17/equalizer.png


Thanks,

Harsh Gupta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130413/033fc680/attachment.html>