Review Request 109984: Renamed attribute names to match Amarok coding style.

Matěj Laitl matej at laitl.cz
Sat Apr 13 12:45:06 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109984/#review30983
-----------------------------------------------------------

Ship it!


Looks good, thanks!

- Matěj Laitl


On April 12, 2013, 10:37 p.m., Harsh Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109984/
> -----------------------------------------------------------
> 
> (Updated April 12, 2013, 10:37 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Renamed attribute names to match Amarok coding style.
> Note : This patch must be applied before "FIX Pre-amplifier in equalizer doesn't work" patch.
> 
> 
> Diffs
> -----
> 
>   src/dialogs/EqualizerDialog.cpp 7299e9a 
>   src/dialogs/EqualizerDialog.h fd9032b 
>   src/EngineController.cpp 86ad837 
> 
> Diff: http://git.reviewboard.kde.org/r/109984/diff/
> 
> 
> Testing
> -------
> 
> Ok
> 
> 
> Thanks,
> 
> Harsh Gupta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130413/0a3f4c33/attachment.html>


More information about the Amarok-devel mailing list