Review Request 109879: Small cleanups in playlists

Tatjana Gornak t.gornak at yandex.ru
Sun Apr 7 02:27:31 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109879/
-----------------------------------------------------------

(Updated April 7, 2013, 2:27 a.m.)


Review request for Amarok.


Description
-------

In review request 109758 Mat?j has pointed on some issues which appear not only in new asx implementation.

- number of includes was minimalized
- common routine for relative urls processing
- trackLocation is const method now


Diffs (updated)
-----

  src/core-impl/playlists/types/file/PlaylistFile.h d3bc640 
  src/core-impl/playlists/types/file/PlaylistFile.cpp 36987c6 
  src/core-impl/playlists/types/file/m3u/M3UPlaylist.cpp 6280442 
  src/core-impl/playlists/types/file/pls/PLSPlaylist.cpp 225dc0b 
  src/core-impl/playlists/types/file/xspf/XSPFPlaylist.cpp 6ec7bfd 

Diff: http://git.reviewboard.kde.org/r/109879/diff/


Testing
-------


Thanks,

Tatjana Gornak

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130407/b0c26aa4/attachment-0001.html>


More information about the Amarok-devel mailing list