Review Request 100176: Fetch cover for DAAP Albums #240060

[Matěj Laitl]

> On April 5, 2013, 8:33 p.m., Albert Astals Cid wrote:
> > If this doesn't get any action before my next janitorial round I'll discard the Review Request understanding nooone cares enough to push this forward.

Looking at the code, this seems still valuable for Amarok. I'll try to get some DAAP server to test and perhaps merge this, please leave it sitting for a bit more time (sorry).


- Matěj


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100176/#review30527
-----------------------------------------------------------


On Nov. 28, 2010, 3:03 p.m., Dennis Francis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100176/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2010, 3:03 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> This is just a copy and paste attempt to introduce cover fetch functionality for DAAP albums. I used PlaydarMeta.h/.cpp as the reference.
> 
> Please suggest better methods !
> 
> The cover arts does not persists between multiple runs of amarok; it seems to load the art from internet everytime. Should I be using ServiceAlbumCoverDownloader which has implemented caching ?
> 
> 
> This addresses bug 240060.
>     https://bugs.kde.org/show_bug.cgi?id=240060
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/daap/DaapMeta.h 8187d1e 
>   src/core-impl/collections/daap/DaapMeta.cpp 61aa0db 
> 
> Diff: http://git.reviewboard.kde.org/r/100176/diff/
> 
> 
> Testing
> -------
> 
> I am using a firefly DAAP server. 
> Cover art is getting fetched in non-blocking mode.
> 
> 
> Thanks,
> 
> Dennis Francis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130406/6f1165d5/attachment.html>