Review Request 109846: BR 259862, 222571: Add options to pause playback on suspend and inhibit automatic suspend if playing

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109846/#review30420
-----------------------------------------------------------

Ship it!


Nice work, this patch is good to go. Just please resolve some nitpicks below and add ChangeLog entry under FEATURES.


src/EngineController.h
<http://git.reviewboard.kde.org/r/109846/#comment22680>

    reminder: don't forget to remove this line



src/EngineController.h
<http://git.reviewboard.kde.org/r/109846/#comment22679>

    You don't need to introduce this attribute at all...



src/EngineController.cpp
<http://git.reviewboard.kde.org/r/109846/#comment22681>

    ...just call new PowerManager( this );



src/playback/PowerManager.h
<http://git.reviewboard.kde.org/r/109846/#comment22682>

    Nitpick: we prefer <QObject> -style includes.



src/playback/PowerManager.cpp
<http://git.reviewboard.kde.org/r/109846/#comment22683>

    These seem to fit on one 90-char line


- Matěj Laitl


On April 4, 2013, 6:57 p.m., Anmol Ahuja wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109846/
> -----------------------------------------------------------
> 
> (Updated April 4, 2013, 6:57 p.m.)
> 
> 
> Review request for Amarok and Oliver Henshaw.
> 
> 
> Description
> -------
> 
> 1. Added "Suspend Options" to the PlaybackConfig Dialog, with two options:
>      Pause playback on suspend
>      Inhibit suspend if playing
> 2. Created a PowerManager class to handle suspend behavior
> 
> Fixes:
> BR 259862 - Amarok does not inhibit suspend while playing
> BR 222571 - Amarok pause on suspend
> 
> 
> Diffs
> -----
> 
>   src/playback/PowerManager.h PRE-CREATION 
>   src/configdialog/dialogs/PlaybackConfig.ui 3a79e43 
>   src/amarokconfig.kcfg fbe5497 
>   src/EngineController.cpp 52bfd90 
>   src/EngineController.h 5de4beb 
>   src/CMakeLists.txt 990f313 
>   src/playback/PowerManager.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109846/diff/
> 
> 
> Testing
> -------
> 
> Works as expected
> 
> 
> File Attachments
> ----------------
> 
> PlaybackConfig Dialog
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/04/03/snapshot11.png
> 
> 
> Thanks,
> 
> Anmol Ahuja
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130404/c4f63416/attachment.html>