Review Request 109846: BR 259862, 222571: Add options to pause playback on suspend and inhibit automatic suspend if playing

[Anmol Ahuja]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109846/
-----------------------------------------------------------

(Updated April 4, 2013, 9:33 p.m.)


Review request for Amarok.


Changes
-------

Changed slot name to fit naming convention


Description
-------

1. Added "Suspend Options" to the PlaybackConfig Dialog, with two options:
     Pause playback on suspend
     Inhibit suspend if playing
2. Created a PowerManager class to handle suspend behavior

Fixes:
BR 259862 - Amarok does not inhibit suspend while playing
BR 222571 - Amarok pause on suspend


Diffs (updated)
-----

  src/CMakeLists.txt 990f313 
  src/EngineController.cpp 52bfd90 
  src/PowerManager.h PRE-CREATION 
  src/PowerManager.cpp PRE-CREATION 
  src/amarokconfig.kcfg fbe5497 
  src/configdialog/dialogs/PlaybackConfig.ui 3a79e43 

Diff: http://git.reviewboard.kde.org/r/109846/diff/


Testing
-------

Works as expected


File Attachments
----------------

PlaybackConfig Dialog
  http://git.reviewboard.kde.org/media/uploaded/files/2013/04/03/snapshot11.png


Thanks,

Anmol Ahuja

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130404/fb2695d9/attachment.html>