Review Request 109794: Fix spacing of SIGNAL and SLOT macros in connect() calls according to Amarok style guidelines

Matěj Laitl matej at laitl.cz
Tue Apr 2 14:23:27 UTC 2013 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109794/#review30274
-----------------------------------------------------------


Thanks, this was a long overdue work. git says this patch has a few problems:

signalslot.patch:44: space before tab in indent.
        connect( engine, SIGNAL(trackPlaying(Meta::TrackPtr)),
signalslot.patch:45: space before tab in indent.
                this, SLOT(jumpToPlaying()) );
signalslot.patch:1389: trailing whitespace.
      SLOT(slotAvatarJobData(KIO::Job*,QByteArray)) );    
signalslot.patch:5833: trailing whitespace.
    connect( m_worker, SIGNAL(trackAdded(Meta::TrackPtr)), 
signalslot.patch:5837: trailing whitespace.
    connect( m_worker, SIGNAL(done(ThreadWeaver::Job*)), 
error: patch failed: src/DirectoryLoader.cpp:76
error: src/DirectoryLoader.cpp: patch does not apply
error: patch failed: src/browsers/playlistbrowser/DynamicBiasWidgets.cpp:114
error: src/browsers/playlistbrowser/DynamicBiasWidgets.cpp: patch does not apply
error: patch failed: src/playlistmanager/PlaylistManager.cpp:314
error: src/playlistmanager/PlaylistManager.cpp: patch does not apply
error: patch failed: tests/TestDirectoryLoader.cpp:46
error: tests/TestDirectoryLoader.cpp: patch does not apply

Please rebase (or rerun the script) on top of current master (there have been some big changes in playlists), fix the whitespace errors and update the patch.

- Matěj Laitl


On March 31, 2013, 8:59 a.m., Anmol Ahuja wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109794/
> -----------------------------------------------------------
> 
> (Updated March 31, 2013, 8:59 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Fix spacing of SIGNAL and SLOT macros in connect() calls according to Amarok style guidelines
> 
> Used this script:
> https://qt.gitorious.org/qt/qt/trees/v4.7.3/util/normalize
> 
> 
> Diffs
> -----
> 
>   playground/src/context/applets/coverbling/CoverBling.cpp 9401514 
>   playground/src/context/applets/coverbling/CoverBlingApplet.cpp 5b355ba 
>   playground/src/context/applets/coverbling/PhotoBrowser.cpp 856e9c2 
>   playground/src/context/applets/coverbling/pictureflow.cpp 057e8d1 
>   playground/src/context/applets/covergrid/CoverGridApplet.cpp 2432df6 
>   src/ActionClasses.cpp bb68c64 
>   src/AmarokMimeData.cpp edd4279 
>   src/AmarokProcess.cpp fc13307 
>   src/App.cpp 416d4dc 
>   src/DirectoryLoader.cpp bd7fa34 
>   src/EngineController.cpp 58d7360 
>   src/LastfmReadLabelCapability.cpp f0929ea 
>   src/MainWindow.cpp 9c6fb49 
>   src/MediaDeviceCache.cpp c9758cd 
>   src/MediaDeviceMonitor.cpp dd22114 
>   src/OpmlParser.cpp a935038 
>   src/ScriptManager.cpp 2fd96ee 
>   src/ScriptUpdater.cpp d1b1ccb 
>   src/SvgHandler.cpp 4f5335b 
>   src/TrayIcon.cpp 606b644 
>   src/aboutdialog/ExtendedAboutDialog.cpp eca67d9 
>   src/aboutdialog/OcsPersonItem.cpp 1174c0b 
>   src/aboutdialog/OcsPersonListWidget.cpp 1a4af3d 
>   src/aboutdialog/libattica-ocsclient/activitylistjob.cpp d8c4bef 
>   src/aboutdialog/libattica-ocsclient/categorylistjob.cpp cf8fadc 
>   src/aboutdialog/libattica-ocsclient/contentjob.cpp 132fe36 
>   src/aboutdialog/libattica-ocsclient/contentlistjob.cpp c85d1ba 
>   src/aboutdialog/libattica-ocsclient/eventjob.cpp d458905 
>   src/aboutdialog/libattica-ocsclient/eventlistjob.cpp 7cf59b7 
>   src/aboutdialog/libattica-ocsclient/folderlistjob.cpp de30a74 
>   src/aboutdialog/libattica-ocsclient/knowledgebasejob.cpp 8558719 
>   src/aboutdialog/libattica-ocsclient/knowledgebaselistjob.cpp 2dab20a 
>   src/aboutdialog/libattica-ocsclient/messagelistjob.cpp 3f32a84f 
>   src/aboutdialog/libattica-ocsclient/personjob.cpp 722f343 
>   src/aboutdialog/libattica-ocsclient/personlistjob.cpp 6dc415b 
>   src/aboutdialog/libattica-ocsclient/postjob.cpp fd790ac 
>   src/amarokurls/AmarokUrlAction.cpp b04b7a4 
>   src/amarokurls/BookmarkCurrentButton.cpp d4b3a19 
>   src/amarokurls/BookmarkManagerWidget.cpp 1806a6b 
>   src/amarokurls/BookmarkMetaActions.cpp 9a11a94 
>   src/amarokurls/BookmarkTreeView.cpp 7a033e0 
>   src/browsers/BrowserBreadcrumbItem.cpp ad485c6 
>   src/browsers/BrowserBreadcrumbWidget.cpp 3b789c2 
>   src/browsers/BrowserCategoryList.cpp ad0079b 
>   src/browsers/BrowserDock.cpp dabe43d 
>   src/browsers/BrowserMessageArea.cpp dc36257 
>   src/browsers/CollectionTreeItem.cpp 26cd253 
>   src/browsers/CollectionTreeItemModel.cpp fa194b1 
>   src/browsers/CollectionTreeItemModelBase.cpp 30067a1 
>   src/browsers/CollectionTreeView.cpp aac232a 
>   src/browsers/SingleCollectionTreeItemModel.cpp babfc64 
>   src/browsers/collectionbrowser/CollectionWidget.cpp 81960b1 
>   src/browsers/filebrowser/FileBrowser.cpp 167fd33 
>   src/browsers/filebrowser/FileView.cpp 61b27ea 
>   src/browsers/playlistbrowser/APGCategory.cpp e2acb9a 
>   src/browsers/playlistbrowser/DynamicBiasWidgets.cpp af4cd33 
>   src/browsers/playlistbrowser/DynamicCategory.cpp 0e1a4af 
>   src/browsers/playlistbrowser/DynamicView.cpp 58c82e4 
>   src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp 3478f68 
>   src/browsers/playlistbrowser/PlaylistBrowserFilterProxy.cpp 84439fa 
>   src/browsers/playlistbrowser/PlaylistBrowserModel.cpp 213af3b 
>   src/browsers/playlistbrowser/PlaylistBrowserView.cpp c885f7c 
>   src/browsers/playlistbrowser/PlaylistsInFoldersProxy.cpp 0ccaf93 
>   src/browsers/playlistbrowser/PodcastCategory.cpp 4631d27 
>   src/browsers/playlistbrowser/QtGroupingProxy.cpp 24f611c 
>   src/browsers/servicebrowser/ServiceBrowser.cpp 6f576a1 
>   src/configdialog/ConfigDialog.cpp 320e6ab 
>   src/configdialog/dialogs/CollectionConfig.cpp 5f546ac 
>   src/configdialog/dialogs/DatabaseConfig.cpp 77ea254 
>   src/configdialog/dialogs/NotificationsConfig.cpp d558325 
>   src/configdialog/dialogs/PlaybackConfig.cpp c4f357b 
>   src/context/Applet.cpp fd5abe9 
>   src/context/ContextDock.cpp a445677 
>   src/context/ContextView.cpp e41638d 
>   src/context/ToolbarView.cpp 679f027 
>   src/context/applets/currenttrack/CurrentTrack.cpp ff3bec7 
>   src/context/applets/info/InfoApplet.cpp f215885 
>   src/context/applets/labels/LabelsApplet.cpp 2df1173 
>   src/context/applets/lyrics/LyricsApplet.cpp 2394964 
>   src/context/applets/photos/PhotosApplet.cpp ed26f33 
>   src/context/applets/photos/PhotosScrollWidget.cpp 555dfda 
>   src/context/applets/songkick/SongkickApplet.cpp 8d1b468 
>   src/context/applets/tabs/TabsApplet.cpp 531a257 
>   src/context/applets/tabs/TabsView.cpp a49b50d 
>   src/context/containments/verticallayout/VerticalAppletLayout.cpp a9c6db7 
>   src/context/containments/verticallayout/VerticalToolbarContainment.cpp 8fa6f9b 
>   src/context/engines/current/CurrentEngine.cpp 41c1a39 
>   src/context/engines/labels/LabelsEngine.cpp ba6d369 
>   src/context/engines/lyrics/LyricsEngine.cpp 2befa91 
>   src/context/engines/photos/PhotosEngine.cpp 85cca30 
>   src/context/engines/songkick/SongkickEngine.cpp b641735 
>   src/context/engines/tabs/TabsEngine.cpp 98aa84d 
>   src/context/engines/upcomingevents/UpcomingEventsEngine.cpp 689323c 
>   src/context/engines/wikipedia/WikipediaEngine.cpp e08940e 
>   src/context/popupdropper/libpud/PopupDropper.cpp 1f902e8 
>   src/context/popupdropper/libpud/PopupDropperItem.cpp dc0c02f 
>   src/context/toolbar/AppletItemOverlay.cpp 8198b73 
>   src/context/toolbar/AppletToolbar.cpp 4c98774 
>   src/context/toolbar/AppletToolbarAddItem.cpp d04e376 
>   src/context/toolbar/AppletToolbarAppletItem.cpp b81f981 
>   src/context/toolbar/AppletToolbarConfigItem.cpp 68ff75e 
>   src/context/widgets/ContainmentArrow.cpp efd6721 
>   src/context/widgets/RecentlyPlayedListWidget.cpp c9a8356 
>   src/context/widgets/TextScrollingWidget.cpp 5aa86b8 
>   src/context/widgets/TrackWidget.cpp 86ac01d 
>   src/core-impl/capabilities/AlbumActionsCapability.cpp cca5952 
>   src/core-impl/collections/audiocd/AudioCdCollectionLocation.cpp be13551 
>   src/core-impl/collections/audiocd/FormatSelectionDialog.cpp 7ae2563 
>   src/core-impl/collections/daap/DaapCollection.cpp 5d1bd9b 
>   src/core-impl/collections/daap/daapreader/Reader.cpp 127cbf6 
>   src/core-impl/collections/daap/daapreader/authentication/contentfetcher.cpp 8dba010 
>   src/core-impl/collections/db/DatabaseCollection.cpp 0d47b0f 
>   src/core-impl/collections/db/MountPointManager.cpp 757f5dd 
>   src/core-impl/collections/db/sql/SqlCollection.cpp 45e6736 
>   src/core-impl/collections/db/sql/SqlCollectionLocation.cpp 11fa33e 
>   src/core-impl/collections/db/sql/SqlRegistry.cpp 2165234 
>   src/core-impl/collections/ipodcollection/IpodCollection.cpp fa7b6d6 
>   src/core-impl/collections/mediadevicecollection/MediaDeviceCollection.cpp bdc76c6 
>   src/core-impl/collections/mediadevicecollection/MediaDeviceCollectionLocation.cpp f60aff6 
>   src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.cpp c1b76f5 
>   src/core-impl/collections/mtpcollection/handler/MtpHandler.cpp a8d9f52 
>   src/core-impl/collections/nepomukcollection/NepomukCollection.cpp 22ecda2 
>   src/core-impl/collections/nepomukcollection/NepomukConstructMetaJob.cpp bc23ad4 
>   src/core-impl/collections/playdarcollection/PlaydarCollection.cpp 6d291fe 
>   src/core-impl/collections/playdarcollection/PlaydarQueryMaker.cpp 8676a17 
>   src/core-impl/collections/playdarcollection/support/Controller.cpp 186f33c 
>   src/core-impl/collections/playdarcollection/support/ProxyResolver.cpp 035fbde 
>   src/core-impl/collections/proxycollection/ProxyCollection.cpp 36252fd 
>   src/core-impl/collections/proxycollection/ProxyCollectionMeta.cpp ca6c460 
>   src/core-impl/collections/proxycollection/ProxyCollectionQueryMaker.cpp 486eec9 
>   src/core-impl/collections/support/CollectionManager.cpp 2433ee2 
>   src/core-impl/collections/support/FileCollectionLocation.cpp b215490 
>   src/core-impl/collections/support/MemoryQueryMaker.cpp eece2f7 
>   src/core-impl/collections/umscollection/UmsCollection.cpp 296d78d 
>   src/core-impl/collections/umscollection/UmsCollectionLocation.cpp e0ba0ac 
>   src/core-impl/collections/umscollection/podcasts/UmsPodcastProvider.cpp 1a4a934 
>   src/core-impl/collections/upnpcollection/UpnpBrowseCollection.cpp e416107 
>   src/core-impl/collections/upnpcollection/UpnpCollectionFactory.cpp 60a2356 
>   src/core-impl/collections/upnpcollection/UpnpQueryMaker.cpp 0e7a214 
>   src/core-impl/collections/upnpcollection/UpnpQueryMakerInternal.cpp a76fc0d 
>   src/core-impl/collections/upnpcollection/UpnpSearchCollection.cpp a37f1d7 
>   src/core-impl/logger/ProxyLogger.cpp 143dedc 
>   src/core-impl/meta/timecode/TimecodeObserver.cpp ad8b811 
>   src/core-impl/podcasts/sql/PodcastFilenameLayoutConfigDialog.cpp ac646aa 
>   src/core-impl/podcasts/sql/PodcastSettingsDialog.cpp f7a109f 
>   src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 0da9b51 
>   src/core/collections/CollectionLocation.cpp aecc068 
>   src/core/collections/MetaQueryMaker.cpp 0b7a2dd 
>   src/core/collections/QueryMaker.cpp 877840f 
>   src/core/collections/support/TrackForUrlWorker.cpp 864d91a 
>   src/core/podcasts/PodcastImageFetcher.cpp 139d4cd 
>   src/core/podcasts/PodcastReader.cpp a801e88 
>   src/core/transcoding/TranscodingController.cpp 6cf7e76 
>   src/covermanager/CoverFetcher.cpp 1ce5c2d 
>   src/covermanager/CoverFoundDialog.cpp 7a9d511 
>   src/covermanager/CoverManager.cpp ae516b2 
>   src/databaseimporter/DatabaseImporter.cpp 86e6e13 
>   src/databaseimporter/amarok14/FastForwardImporter.cpp ce5e069 
>   src/databaseimporter/amarok14/FastForwardImporterConfig.cpp dff4d14 
>   src/databaseimporter/amarok14/FastForwardWorker.cpp 0988c19 
>   src/databaseimporter/itunes/ITunesImporter.cpp 2148d0e 
>   src/dbus/DBusQueryHelper.cpp c7cdbfb 
>   src/dbus/mpris1/PlayerHandler.cpp c2d1139 
>   src/dbus/mpris1/TrackListHandler.cpp 5b3b0f7 
>   src/dbus/mpris2/MediaPlayer2AmarokExtensions.cpp 60856c1 
>   src/dbus/mpris2/MediaPlayer2Player.cpp 214b87d 
>   src/dialogs/CollectionSetup.cpp d11a274 
>   src/dialogs/DatabaseImporterDialog.cpp 596d6c1 
>   src/dialogs/EditFilterDialog.cpp 3e930cf 
>   src/dialogs/EqualizerDialog.cpp 7d62e10 
>   src/dialogs/MusicBrainzTagger.cpp e831ddc 
>   src/dialogs/OrganizeCollectionDialog.cpp 0cf02b8 
>   src/dialogs/TagDialog.cpp 41477f2 
>   src/dialogs/TagGuesserDialog.cpp 6357f59 
>   src/dialogs/deviceconfiguredialog.cpp bd95ff8 
>   src/dialogs/transferdialog.cpp 5b28459 
>   src/dynamic/Bias.cpp b1f7ede 
>   src/dynamic/BiasFactory.cpp d0cdb0d 
>   src/dynamic/BiasSolver.cpp 36c0204 
>   src/dynamic/BiasedPlaylist.cpp 24c1a81 
>   src/dynamic/biases/AlbumPlayBias.cpp 82b7884 
>   src/dynamic/biases/EchoNestBias.cpp 48a8e8e 
>   src/dynamic/biases/PartBias.cpp 3930791 
>   src/dynamic/biases/QuizPlayBias.cpp b04d2a7 
>   src/dynamic/biases/SearchQueryBias.cpp c28a54a 
>   src/dynamic/biases/TagMatchBias.cpp f38f880 
>   src/likeback/LikeBack.cpp a3e555b 
>   src/likeback/LikeBackBar.cpp 11e8776 
>   src/likeback/LikeBackDialog.cpp 5d11f72 
>   src/mac/GrowlInterface.cpp cb553ed 
>   src/musicbrainz/MusicBrainzFinder.cpp 724c04d 
>   src/musicbrainz/MusicBrainzTags.cpp 08d4fdf 
>   src/musicbrainz/MusicDNSFinder.cpp d7b2da2 
>   src/network/NetworkAccessViewer.cpp 4ea3951 
>   src/playlist/PlaylistActions.cpp 00bf13a 
>   src/playlist/PlaylistBreadcrumbItem.cpp f9df4f5 
>   src/playlist/PlaylistController.cpp e5bde8b 
>   src/playlist/PlaylistDock.cpp aa972dc 
>   src/playlist/PlaylistInfoWidget.cpp 8138cc4 
>   src/playlist/PlaylistQueueEditor.cpp f647e37 
>   src/playlist/PlaylistSortWidget.cpp 7689bce 
>   src/playlist/ProgressiveSearchWidget.cpp f96b7bf 
>   src/playlist/layouts/LayoutConfigAction.cpp 90b4585 
>   src/playlist/layouts/LayoutEditDialog.cpp 44f778f 
>   src/playlist/layouts/LayoutEditWidget.cpp faebbfb 
>   src/playlist/layouts/PlaylistLayoutEditDialog.cpp 8c77e7d 
>   src/playlist/navigators/DynamicTrackNavigator.cpp ad17335 
>   src/playlist/navigators/NavigatorConfigAction.cpp 7bfc621 
>   src/playlist/navigators/NonlinearTrackNavigator.cpp 6a61bc0 
>   src/playlist/navigators/RepeatTrackNavigator.cpp 0c47783 
>   src/playlist/navigators/TrackNavigator.cpp 85ddfa0 
>   src/playlist/proxymodels/GroupingProxy.cpp ad0fe92 
>   src/playlist/proxymodels/ProxyBase.cpp 250e1e4 
>   src/playlist/view/listview/InlineEditorWidget.cpp d7c02c5 
>   src/playlist/view/listview/PrettyItemDelegate.cpp 7dae262 
>   src/playlist/view/listview/PrettyListView.cpp 635448d 
>   src/playlist/view/listview/SourceSelectionPopup.cpp 4499090 
>   src/playlistgenerator/ConstraintGroup.cpp e5756a4 
>   src/playlistgenerator/ConstraintSolver.cpp cf7f8b7 
>   src/playlistgenerator/Preset.cpp 6e6c30a 
>   src/playlistgenerator/PresetEditDialog.cpp 6f20547 
>   src/playlistgenerator/PresetModel.cpp 161d60e 
>   src/playlistgenerator/TreeModel.cpp 4ddd4d1 
>   src/playlistgenerator/constraints/Checkpoint.cpp c76683f 
>   src/playlistgenerator/constraints/PlaylistDuration.cpp b72c635 
>   src/playlistgenerator/constraints/PlaylistFileSize.cpp 0429483 
>   src/playlistgenerator/constraints/PlaylistLength.cpp e425c30 
>   src/playlistgenerator/constraints/PreventDuplicates.cpp 27de42a 
>   src/playlistgenerator/constraints/TagMatch.cpp f6a8ee0 
>   src/playlistmanager/PlaylistManager.cpp 89c754b 
>   src/scanner/AbstractDirectoryWatcher.cpp 335b84e 
>   src/scanner/AbstractScanResultProcessor.cpp 3ffccf6 
>   src/scanner/GenericScanManager.cpp 2ba7913 
>   src/scanner/GenericScannerJob.cpp 2d58550 
>   src/scriptengine/AmarokCollectionScript.cpp 6bd14ce 
>   src/scriptengine/AmarokEngineScript.cpp 9d9906d 
>   src/scriptengine/AmarokLyricsScript.cpp eb43a02 
>   src/scriptengine/AmarokNetworkScript.cpp 57b46c4 
>   src/scriptengine/AmarokPlaylistScript.cpp 1d38d4a 
>   src/scriptengine/AmarokScriptableServiceScript.cpp 77f580c 
>   src/services/ServiceAlbumCoverDownloader.cpp 763844f 
>   src/services/ServiceBase.cpp d356962 
>   src/services/ServiceSqlQueryMaker.cpp 77efa2a 
>   src/services/ServiceSqlRegistry.cpp 7dd073b 
>   src/services/amazon/AmazonInfoParser.cpp 806a4fb 
>   src/services/amazon/AmazonItemTreeModel.cpp dbcf265 
>   src/services/amazon/AmazonItemTreeView.cpp a6d7db0 
>   src/services/amazon/AmazonSettingsModule.cpp 369e036 
>   src/services/amazon/AmazonShoppingCartDialog.cpp 905f0e5 
>   src/services/amazon/AmazonShoppingCartView.cpp c1fc593 
>   src/services/amazon/AmazonStore.cpp c41c7f8 
>   src/services/ampache/AddServerDialog.cpp a796b1d 
>   src/services/ampache/AmpacheService.cpp e3b9a40 
>   src/services/ampache/AmpacheSettings.cpp ace3fec 
>   src/services/ampache/LastfmInfoParser.cpp 739b1f2 
>   src/services/gpodder/GpodderProvider.cpp 1bc6e2e 
>   src/services/gpodder/GpodderService.cpp fca9bf3 
>   src/services/gpodder/GpodderServiceModel.cpp 6d63337 
>   src/services/gpodder/GpodderServiceSettings.cpp 6988c78 
>   src/services/jamendo/JamendoMeta.cpp 2068163 
>   src/services/jamendo/JamendoService.cpp 33d82eb 
>   src/services/jamendo/JamendoXmlParser.cpp 7d09bd8 
>   src/services/lastfm/LastFmService.cpp 0612108 
>   src/services/lastfm/LastFmServiceCollection.cpp 774b58f 
>   src/services/lastfm/LastFmServiceSettings.cpp 9ac218b 
>   src/services/lastfm/LastFmTreeModel.cpp 54326a6 
>   src/services/lastfm/LastFmTreeView.cpp 30f7d69 
>   src/services/lastfm/LoveTrackAction.cpp 1cd06d5 
>   src/services/lastfm/SimilarArtistsAction.cpp 0c4001f 
>   src/services/lastfm/biases/LastFmBias.cpp 01401d8 
>   src/services/lastfm/biases/WeeklyTopBias.cpp a653050 
>   src/services/lastfm/meta/LastFmMeta.cpp 4d29358 
>   src/services/magnatune/MagnatuneActions.cpp 15f49d5 
>   src/services/magnatune/MagnatuneAlbumDownloader.cpp 7f52af1 
>   src/services/magnatune/MagnatuneDatabaseWorker.cpp e21dced 
>   src/services/magnatune/MagnatuneDownloadHandler.cpp 1b5ba3b 
>   src/services/magnatune/MagnatuneInfoParser.cpp 752afcd 
>   src/services/magnatune/MagnatuneRedownloadHandler.cpp 6636214 
>   src/services/magnatune/MagnatuneSettingsModule.cpp 444b8f9 
>   src/services/magnatune/MagnatuneStore.cpp 7b611c0 
>   src/services/magnatune/MagnatuneXmlParser.cpp 1bcfb98 
>   src/services/mp3tunes/Mp3tunesHarmonyHandler.cpp d3323ac 
>   src/services/mp3tunes/Mp3tunesService.cpp 4ab0805 
>   src/services/mp3tunes/Mp3tunesServiceCollection.cpp 82a92a5 
>   src/services/mp3tunes/Mp3tunesServiceCollectionLocation.cpp aa61072 
>   src/services/mp3tunes/Mp3tunesServiceQueryMaker.cpp 00a41d0 
>   src/services/mp3tunes/Mp3tunesSettingsModule.cpp 0905401 
>   src/services/mp3tunes/Mp3tunesWorkers.cpp e4ae066 
>   src/services/mp3tunes/harmonydaemon/Mp3tunesHarmonyDaemon.cpp 4c6c995 
>   src/services/opmldirectory/OpmlDirectoryInfoParser.cpp a40ec10 
>   src/services/opmldirectory/OpmlDirectoryModel.cpp ae93e66 
>   src/services/opmldirectory/OpmlDirectoryService.cpp 44ba847 
>   src/services/scriptable/ScriptableServiceQueryMaker.cpp 856f570 
>   src/statusbar/CompoundProgressBar.cpp 77941dc 
>   src/statusbar/KJobProgressBar.cpp 3be03a0 
>   src/statusbar/LongMessageWidget.cpp 0ee5a2b 
>   src/statusbar/ProgressBar.cpp f74a9fe 
>   src/synchronization/SynchronizationBaseJob.cpp f556032 
>   src/toolbar/CurrentTrackToolbar.cpp 086419b 
>   src/toolbar/MainToolbar.cpp 73438ed 
>   src/toolbar/VolumePopupButton.cpp 2385a7d 
>   src/transcoding/TranscodingAssistantDialog.cpp 6bba0ec 
>   src/transcoding/TranscodingJob.cpp cab76a7 
>   src/transcoding/TranscodingPropertySliderWidget.cpp 51aed8c 
>   src/widgets/AmarokDockWidget.cpp 32ffded 
>   src/widgets/AnimatedLabelStack.cpp feff581 
>   src/widgets/BookmarkPopup.cpp a0187b0 
>   src/widgets/BreadcrumbItemButton.cpp 861785e 
>   src/widgets/FilenameLayoutWidget.cpp 7e40684 
>   src/widgets/MetaQueryWidget.cpp 2e89418 
>   src/widgets/Osd.cpp e1e6872 
>   src/widgets/PlayPauseButton.cpp 571dbb1 
>   src/widgets/PrettyTreeView.cpp d047eb8 
>   src/widgets/ProgressWidget.cpp 6cd2fe1 
>   src/widgets/SearchWidget.cpp afa4e7b 
>   src/widgets/SliderWidget.cpp beecb9e 
>   src/widgets/SmartPlaylistEditor.cpp 31bbedb 
>   src/widgets/TokenWithLayout.cpp 50a17e7 
>   src/widgets/TrackActionButton.cpp d8d3a9a 
>   src/widgets/TrackSelectWidget.cpp 5106219 
>   src/widgets/VolumeDial.cpp 4447921 
>   tests/TestDirectoryLoader.cpp b98247d 
>   tests/core-impl/collections/db/sql/TestSqlCollectionLocation.cpp 6e02116 
>   tests/core-impl/collections/db/sql/TestSqlScanManager.cpp 3f1d010 
>   tests/core/collections/CollectionLocationTest.cpp e81a4ac 
>   tests/core/collections/TestQueryMaker.cpp 47abe05 
>   tests/core/collections/support/TestTrackForUrlWorker.cpp 6444434 
>   tests/dynamic/TestDynamicModel.cpp 792f7cf 
>   tests/qt-modeltest/modeltest.cpp 40d7d28 
>   tests/scanner/TestGenericScanManager.cpp 57ecf95 
>   utilities/amzdownloader/AmzDownloader.cpp f476919 
>   utilities/collectionscanner/CollectionScanner.cpp c051ed2 
>   utilities/updatesigner/signer.cpp 99d315f 
> 
> Diff: http://git.reviewboard.kde.org/r/109794/diff/
> 
> 
> Testing
> -------
> 
> Build tests passed
> Everything seems to be working right
> 
> 
> Thanks,
> 
> Anmol Ahuja
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130402/805bba26/attachment-0001.html>

More information about the Amarok-devel mailing list