Review Request: Fix DAAP collections published by Rhythmbox not showing up in Amarok.

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106366/#review19575
-----------------------------------------------------------


I'd like to ship this even if another bug needs to be fixed before this becomes functional.


src/core-impl/collections/daap/DaapCollection.cpp
<http://git.reviewboard.kde.org/r/106366/#comment15565>

    Please use proper Amarok-style indentation: 4 spaces.



src/core-impl/collections/support/CollectionManager.cpp
<http://git.reviewboard.kde.org/r/106366/#comment15566>

    Please remove this bit from the patch. We should solve it differently.


- Matěj Laitl


On Sept. 8, 2012, 7:11 p.m., Daniel Stöckel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106366/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2012, 7:11 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> This simply sends a fake revision-number to the server.
> 
> Also appends the session-id field to the track URLs.
> 
> See: https://bugs.kde.org/show_bug.cgi?id=306351
> See: https://bugs.kde.org/show_bug.cgi?id=306351
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/daap/DaapCollection.h f8655ec 
>   src/core-impl/collections/daap/DaapCollection.cpp 5d1bd9b 
>   src/core-impl/collections/daap/DaapMeta.h 5278b57 
>   src/core-impl/collections/daap/DaapMeta.cpp a2429d7 
>   src/core-impl/collections/daap/daapreader/Reader.cpp b6196e1 
>   src/core-impl/collections/support/CollectionManager.cpp d196403 
> 
> Diff: http://git.reviewboard.kde.org/r/106366/diff/
> 
> 
> Testing
> -------
> 
> - Rhythmbox collections now correctly appear and play in Amarok.
> - Validated that mt-daap collections are still working.
> 
> 
> Thanks,
> 
> Daniel Stöckel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120929/de7f0ac5/attachment.html>