Review Request: WIP - Dedicated equalizer controller

[Ryan McCoskrie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106511/
-----------------------------------------------------------

(Updated Sept. 20, 2012, 11:24 p.m.)


Review request for Amarok.


Changes
-------

Added documentation to the patch.
Note that the explanation of restorePreset() is a guess. The equaliser dialogue insist
on having it. However if it servers the purpose that I think it does, we can safely
remove it. EqualizerPresets::eqCfgRestorePreset is a horrid function anyway.


Description
-------

This patch moves much of the Equalizer Dialogues internal behaviour into a dedicated object accessed via The::equalizer()*. Any component of Amarok looking to adjust equalizer levels (i.e. The equalizer scripting support I'll resubmit some day) should use this interface.

I'm considering as my next steps, merging the EqualizerPresets class with the EqualizerController class and possibly removing dependence on AmarokConfig to make the actual changes..

*The equalizer dialogue is accessed via The::equalizerDialog()


Diffs (updated)
-----

  src/EqualizerController.h PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/106511/diff/


Testing
-------

Checked that Amarok compiles and that the equalizer dialogue still works. Found that enabling/dis-enabling the equalizer forces the track to freeze or restart. Pressing stop and then play will make it continue with the correct preset enabled.


Thanks,

Ryan McCoskrie

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120920/00c5941e/attachment.html>