Review Request: tag reading support for mod, s3m, it and xm files

Wed Sep 12 12:52:11 UTC 2012

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101598/
-----------------------------------------------------------

(Updated Sept. 12, 2012, 12:52 p.m.)

Review request for Amarok.

Changes
-------

Used `git format-patch` instead of `git diff` to create patch in order to include commit message.

Description
-------

This patch adds read/write tag support for mod, s3m, it and xm files if taglib supports it. All new parts are #ifdefed so it won't break if an old taglib version is used.

I wrote a patch for taglib that enables support for these file formats and it will be included in taglib 1.8.0. Here is the pull request:
https://github.com/taglib/taglib/pull/4

Update:
TagLib 1.8 is released and includes my mod, s3m, it and xm patches:
http://taglib.github.com/

This addresses bug 90524.
    https://bugs.kde.org/show_bug.cgi?id=90524

Diffs (updated)
-----

  CMakeLists.txt ebb8064 
  ChangeLog ca4b364 
  README c078afd 
  config-amarok.h.cmake 2d25cc7 
  shared/FileType.h 3c11ed0 
  shared/FileType.cpp 23aee04 
  shared/FileTypeResolver.cpp e69a514 
  shared/tag_helpers/TagHelper.cpp 3365432 

Diff: http://git.reviewboard.kde.org/r/101598/diff/

Testing
-------

Thanks,

Mathias Stephan Panzenböck

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120912/b658ab2c/attachment.html>