Review Request: add cli argument to activate phonon debugging
Harald Sitter
sitter at kde.org
Wed Sep 12 11:35:38 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106431/
-----------------------------------------------------------
Review request for Amarok.
Description
-------
add new argument to activate audio (phonon) debugging
it simply injects the appropriate phonon 4.6+ environment variables in main.cpp
this is very helpful as 99% of all phonon bug reports get a first comment that asks the reporter to get an actual phonon relevant debug log, by making this simpler we can help reporters get relevant data quicker and since it is visually exposed they may even provide initial report logs with phonon debug active thus making bug triage twice as fast
Diffs
-----
src/App.cpp 9b8bbe51e6fb93aef2e528b57ad3f5056f09c85a
src/main.cpp 4a48233ece598c90c6dd080473ec23a91ab2fe05
Diff: http://git.reviewboard.kde.org/r/106431/diff/
Testing
-------
[x] start with --debug-audio
[x] start with --debug
[x] start with --debug --debug-audio
[x] start without any argument
Thanks,
Harald Sitter
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120912/257a2636/attachment.html>
More information about the Amarok-devel
mailing list