Review Request: Fix DAAP collections published by Rhythmbox not showing up in Amarok.

[Bart Cerneels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106366/#review18654
-----------------------------------------------------------



src/core-impl/collections/daap/DaapMeta.cpp
<http://git.reviewboard.kde.org/r/106366/#comment14747>

    Since the playable url now contains a session ID, I wonder if it will still be playable after restart.
    
    This might not be an issue if the track can be resolved using it's uidUrl by the DaapCollection the should become available not long after startup.



src/core-impl/collections/daap/daapreader/Reader.cpp
<http://git.reviewboard.kde.org/r/106366/#comment14746>

    I would move the login assignment to below the connect.


- Bart Cerneels


On Sept. 7, 2012, 12:16 p.m., Daniel Stöckel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106366/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2012, 12:16 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> This simply sends a fake revision-number to the server.
> 
> Also appends the session-id field to the track URLs.
> 
> See: https://bugs.kde.org/show_bug.cgi?id=306351
> See: https://bugs.kde.org/show_bug.cgi?id=306351
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/daap/DaapMeta.h 5278b57 
>   src/core-impl/collections/daap/DaapMeta.cpp a2429d7 
>   src/core-impl/collections/daap/daapreader/Reader.cpp b6196e1 
> 
> Diff: http://git.reviewboard.kde.org/r/106366/diff/
> 
> 
> Testing
> -------
> 
> - Rhythmbox collections now correctly appear and play in Amarok.
> - Validated that mt-daap collections are still working.
> 
> 
> Thanks,
> 
> Daniel Stöckel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120907/d85ad745/attachment.html>