Review Request: Refactoring of Collection config UI code

[Mark Kretschmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106762/
-----------------------------------------------------------

(Updated Oct. 8, 2012, 11:31 a.m.)


Review request for Amarok.


Description
-------

Refactoring the Collection config UI code, by moving move more stuff into the UI file. Also, a resizing issue of the UI was fixed, as well as some other small issues.
    
There is one remaining issue with this patch:
The TreeView in the UI takes up too much vertical space, although the SizePolicy is set to Minimum. I can't figure out why it does that, so I'd welcome help.


Diffs
-----

  src/CMakeLists.txt 9efeb20 
  src/configdialog/dialogs/CollectionConfig.h 02c80e1 
  src/configdialog/dialogs/CollectionConfig.cpp 42ffa1f 
  src/configdialog/dialogs/CollectionConfig.ui 692c3d9 
  src/dialogs/CollectionSetup.h 23d717a 
  src/dialogs/CollectionSetup.cpp 5ae0294 
  src/widgets/CollectionSetupTreeView.h PRE-CREATION 
  src/widgets/CollectionSetupTreeView.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/106762/diff/


Testing
-------

Tested visual sanity of the UI, tested connections with config.


Thanks,

Mark Kretschmann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20121008/67b2c71e/attachment-0001.html>