Review Request: clear filter history

[Matěj Laitl]

> On Nov. 26, 2012, 5:44 p.m., Matěj Laitl wrote:
> > Screenshot: clear button
> > <http://git.reviewboard.kde.org>
> >
> >     I'm not a usability guy, but I really think this button belongs to the context menu of the "Search Collection" KLineEdit.

Manuel, please resolve this remark.


- Matěj


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107476/#review22584
-----------------------------------------------------------


On Nov. 26, 2012, 5:45 p.m., Manuel Finessi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107476/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2012, 5:45 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Hi, 
> this patch implement (very simple) clear filter history.
> 
> 
> This addresses bug 310582.
>     https://bugs.kde.org/show_bug.cgi?id=310582
> 
> 
> Diffs
> -----
> 
>   src/dialogs/EditFilterDialog.cpp 4caabd3 
>   src/widgets/SearchWidget.h 897d843 
>   src/widgets/SearchWidget.cpp afa4e7b 
> 
> Diff: http://git.reviewboard.kde.org/r/107476/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> clear button
>   http://git.reviewboard.kde.org/r/107476/s/854/
> 
> 
> Thanks,
> 
> Manuel Finessi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20121128/f5d9391c/attachment.html>