Review Request: Playlists::Playlist: add metadataChanged() to observer, clean-up, docs
Matěj Laitl
matej at laitl.cz
Tue Nov 27 12:01:35 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107484/
-----------------------------------------------------------
Review request for Amarok, Bart Cerneels, Edward Hades Toroshchin, and Tatjana Gornak.
Description
-------
Playlists::Playlist: add metadataChanged() to observer, clean-up, docs
All observers are made to react on metadataChanged() as appropriate.
TODO: actually call notifyObserversMetadataqChanged() in Playlists
subclasses as appropriate.
Diffs
-----
src/browsers/playlistbrowser/PlaylistBrowserModel.h 8f9febd0636b8dab99daaca6c813b449944396c3
src/browsers/playlistbrowser/PlaylistBrowserModel.cpp afbae7ff5b6cadcd3c0045bcc0b07cdda836573b
src/core-impl/collections/ipodcollection/IpodPlaylistProvider.h 1eff808e91a5c9c9cba64a48eaf172a7d5f5aaaa
src/core-impl/collections/ipodcollection/IpodPlaylistProvider.cpp 6b636270077bced6fd31281926fedf2a969ba630
src/core/playlists/Playlist.h 5cf11f2128c593774d9ed5cae456ee886d09771b
src/core/playlists/Playlist.cpp 86ecaa5b77d41fa95d81bff492f278f8724a835e
src/playlistmanager/SyncedPlaylist.h f7716d20010bcb7c32605e606e03bd8c5425fa96
src/playlistmanager/SyncedPlaylist.cpp 1607914f9a1f461959a84b255a3bab3ad6c8a06c
Diff: http://git.reviewboard.kde.org/r/107484/diff/
Testing
-------
Amarok still works fine incl. Saved Playlists.
Thanks,
Matěj Laitl
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20121127/6cadb5f1/attachment.html>
More information about the Amarok-devel
mailing list