Review Request: Statistics Synchronization: final review request

Edward Hades Toroshchin edward.hades at gmail.com
Mon Nov 19 10:23:23 UTC 2012


On Sun, Nov 18, 2012 at 10:43:07PM -0000, Matěj Laitl wrote:
> Cannot be done. There couldn't be any "BlockingQueryMaker only created
> in the main thread" restriction (which would make it useless) and
> without it, the code wouldn't work.

You have this restriction in StatSync::Provider, and according to
yourself. And it won't make it useless. Again, your Provider is in main
thread, but it isn't useless, despite that it's essentially a blocking
interface to QueryMaker.

-- 
Edward "Hades" Toroshchin
dr_lepper on irc.freenode.org


More information about the Amarok-devel mailing list