Review Request: TrackProvider non virtual functions implemented for Nepomuk Collection
Phalgun Guduthur
phalgun.guduthur at gmail.com
Fri Nov 9 14:24:27 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107161/
-----------------------------------------------------------
(Updated Nov. 9, 2012, 2:24 p.m.)
Review request for Amarok, Edward Hades Toroshchin and Vishesh Handa.
Changes
-------
Fixed the minor nitpicks of vHanda.
Would like someone to go through the minor changes before I can merge it to the master.
Description
-------
First footstep in completing the Nepomuk Collection.
The non virtual methods belonging to TrackProvider implemented.
Repeated documentation to help vHanda understand the purpose of those functions.
Diffs (updated)
-----
src/core-impl/collections/nepomukcollection/NepomukCollection.h d920ff6
src/core-impl/collections/nepomukcollection/NepomukCollection.cpp 0593697
Diff: http://git.reviewboard.kde.org/r/107161/diff/
Testing
-------
Minimal.
Thanks,
Phalgun Guduthur
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20121109/f76f0626/attachment.html>
More information about the Amarok-devel
mailing list