Review Request: Fix: Recently played tracks are not updated in currrent track applet.

[Ralf Engels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101015/#review14183
-----------------------------------------------------------


Sorry,
I can't really see how the fixes will fix "Recently played tracks are not updated in current track applet".
This fix does some UI changes and a constant one minute update when amarok is not playing.

You might want to change the title for the review request.


src/context/applets/currenttrack/currentTrackSettings.ui
<http://git.reviewboard.kde.org/r/101015/#comment11213>

    What was the reason to make the applet this much wider? Was the old width incorrect?



src/context/widgets/RecentlyPlayedListWidget.cpp
<http://git.reviewboard.kde.org/r/101015/#comment11217>

    Any reason why 60 seconds and not e.g. 120 seconds, or 10 or something in between?



src/context/widgets/RecentlyPlayedListWidget.cpp
<http://git.reviewboard.kde.org/r/101015/#comment11215>

    Argh, trailing spaces.



src/context/widgets/RecentlyPlayedListWidget.cpp
<http://git.reviewboard.kde.org/r/101015/#comment11216>

    As I understand, this means that if Amarok is not playing it will still update the recent played widget every 60 seconds triggering a repaint for the widget.
    
    Could you maybe just trigger one last update and then not use up cpu power?


- Ralf Engels


On March 29, 2012, 6:07 p.m., Conrad Hübler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101015/
> -----------------------------------------------------------
> 
> (Updated March 29, 2012, 6:07 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> The recentlyplayedtracks-widget from the current track applet does not update the last played time of recently played tracks. It now happens, every 60000 msec and after amarok stops.
> 
> It is just a hack for the next release making this applet working as it should, but it is not a proper solution for this problem.
> 
> 
> Diffs
> -----
> 
>   src/context/applets/currenttrack/CurrentTrack.h e023e91 
>   src/context/applets/currenttrack/CurrentTrack.cpp 916c829 
>   src/context/applets/currenttrack/currentTrackSettings.ui c006384 
>   src/context/widgets/RecentlyPlayedListWidget.h 37032cb 
>   src/context/widgets/RecentlyPlayedListWidget.cpp 3b7bd72 
> 
> Diff: http://git.reviewboard.kde.org/r/101015/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Conrad Hübler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120526/432edf97/attachment-0001.html>