Amarok 2.5.0 has a bad memory leak

Erik Hovland erik at hovland.org
Wed May 23 22:16:01 UTC 2012


> Out of curiosity:
> Why use a QShardPointer and not directly allocate the object on the stack?
> Would do the same.

You're probably right. I was staring at the code too long to recognize such
simplicity. Reworked patch attached.

E

-- 
Erik Hovland
erik at hovland.org
http://hovland.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-memory-leak-in-sort-widget.patch
Type: application/octet-stream
Size: 1423 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120523/280389b1/attachment.obj>


More information about the Amarok-devel mailing list