Review Request: Revert broken workaround previously not working solid fstab monitoring

[Stefan Brüns]

> On May 7, 2012, 4:20 p.m., Bart Cerneels wrote:
> > Why not use ifdef's to conditionally compile in the workaround?

Because the workaround is broken?

Specifically, although it works, it polls *every second* for a list of all mountpoints (parsing mtab and fstab) and all Solid storage devices, causing an insane amount of dbus messages adressed to udisks-daemon.

It is only needed in case music is stored on CIFS or NFS, but causes substantial CPU load for everyone.


- Stefan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104878/#review13544
-----------------------------------------------------------


On May 7, 2012, 1:59 p.m., Stefan Brüns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104878/
> -----------------------------------------------------------
> 
> (Updated May 7, 2012, 1:59 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> As the needed fix in solid is upstream since SC 4.8.2, the workaround should be removed. For details, see the BR.
> 
> Anyone insisting on using an older version of kdelibs should apply the solid patch.
> 
> 
> This addresses bug 293926.
>     https://bugs.kde.org/show_bug.cgi?id=293926
> 
> 
> Diffs
> -----
> 
>   src/MediaDeviceCache.h a48d453 
>   src/MediaDeviceCache.cpp 15583b8 
> 
> Diff: http://git.reviewboard.kde.org/r/104878/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Stefan Brüns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120514/8682df19/attachment.html>