Review Request: Prevent amarok from merging tracks with same title but different track numbers

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104423/#review11948
-----------------------------------------------------------


This patch looks very sane, thanks. What about adding disc number to the track key too? I can imagine a multi disc album with following tracks:
CD1 01 Intro
(...)
CD2 01 Intro


src/core/meta/support/MetaKeys.h
<http://git.reviewboard.kde.org/r/104423/#comment9458>

    very minor: this could be removed now


- Matěj Laitl


On March 27, 2012, 6:16 a.m., Alexey Neyman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104423/
> -----------------------------------------------------------
> 
> (Updated March 27, 2012, 6:16 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> In merged view, amarok merges the tracks if the tracks in an album have the same
> title even though they have different track number. It does not do so when shown
> collections separately. As far as I understand, the merged view is supposed to
> eliminate identical tracks - but tracks with different track numbers are obviously
> not identical.
> 
> A couple of examples where album has more than one track with same name:
> - I have a concert recording where between the songs there are author's commentaries.
> Naturally, there are 11 tracks titled "Commentary"
> - Classical pieces often have parts titled by the tempo, e.g. track #2 "Allegro".
> Oftentimes there's more than one part with the same tempo in a piece.
> 
> This patch adds track number to Meta::TrackKey class - the ProxyCollection class
> which implements merged view uses Meta::TrackKey to determine if tracks are
> identical.
> 
> 
> Diffs
> -----
> 
>   src/core/meta/support/MetaKeys.h e2227e6 
>   src/core/meta/support/MetaKeys.cpp 7f8ce7d 
> 
> Diff: http://git.reviewboard.kde.org/r/104423/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexey Neyman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120328/02ad5e41/attachment.html>