Review Request: Add composer button to wikipedia applet

[Ryan McCoskrie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104327/#review11865
-----------------------------------------------------------


Just found out about the Wikipedia applet having separate language controls. This patch works fine.

- Ryan McCoskrie


On March 26, 2012, 6:50 a.m., Ryan McCoskrie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104327/
> -----------------------------------------------------------
> 
> (Updated March 26, 2012, 6:50 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Adds a new composer button for the Wikipedia applet.
> 
> Currently only works in English.
> 
> 
> This addresses bug 272982.
>     https://bugs.kde.org/show_bug.cgi?id=272982
> 
> 
> Diffs
> -----
> 
>   src/context/applets/wikipedia/WikipediaApplet.h 897a32c 
>   src/context/applets/wikipedia/WikipediaApplet.cpp e326804 
>   src/context/applets/wikipedia/WikipediaApplet_p.h b0d6116 
>   src/context/engines/wikipedia/WikipediaEngine.cpp a4ee870 
> 
> Diff: http://git.reviewboard.kde.org/r/104327/diff/
> 
> 
> Testing
> -------
> 
> Compiled Amarok, changed a file to have a different musician name to the composer name and pressed button. Everything works as expected.
> This patch is simply a case of copying, pasting, substituteing artist with composer so new bugs are extremely unlikely.
> 
> 
> Thanks,
> 
> Ryan McCoskrie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120326/70696639/attachment-0001.html>