Review Request: Removes unnecessary OpenGL constraints from the spectrum analyzer

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104330/#review11540
-----------------------------------------------------------


I've tried the patch. Previously the spectrum analyzer said: no sample buffer support. Now it pretends it is working but shows nothing or just some corrupted image that doesn't update. Following messages appear in debug output:
QEglContext::swapBuffers(): "Bad surface (0x300D)" 

 My card is Intel Sandy Bridge Integrated Graphics Controller. Perhaps lifting the limitation isn't this simple?

- Matěj Laitl


On March 18, 2012, 1:46 p.m., Daniel Dewald wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104330/
> -----------------------------------------------------------
> 
> (Updated March 18, 2012, 1:46 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Removes some unnecessary OpenGL constraints from the spectrum analyzer (See Bug# 290327). Also extended the remaining constraints error messages to clarify that its an OpenGL problem.
> 
> 
> This addresses bug 290327.
>     https://bugs.kde.org/show_bug.cgi?id=290327
> 
> 
> Diffs
> -----
> 
>   src/context/applets/spectrumanalyzer/SpectrumAnalyzerApplet.cpp 8d5ad25 
> 
> Diff: http://git.reviewboard.kde.org/r/104330/diff/
> 
> 
> Testing
> -------
> 
> Since my graphic card supports all the removed constraints I can't really test if the problem is gone now. Someone with an older card should test if the error message is gone now.
> 
> 
> Thanks,
> 
> Daniel Dewald
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120318/ce37e076/attachment.html>