Review Request: Fix bug 295275

[Alexey Neyman]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104321/
-----------------------------------------------------------

Review request for Amarok.


Description
-------

This patch fixes issue https://bugs.kde.org/show_bug.cgi?id=295275; here is
a discussion from #amarok:

[15:41:30] <stilor> Sentynel: could you reproduce if the processEvents() loop is removed from AmarokMimeData::tracks()?
[15:42:43] <stilor> idea is, drag-n-drop, AFAIU is two events, "drag" and "drop". The 1st event is fetched before CollectionTreeView::dragEnterEvent is called
[15:42:58] <Sentynel> sounds plausible, let's have a look
[15:43:10] <stilor> so this processEvents() loop fetches the "drop" event for which it doesn't have source
[15:44:45] <stilor> I played aggressively with my mouse for a few minutes and can't get it to crash anymore
[15:44:56] <Sentynel> yeah I can't get it to crash either
[15:45:04] <Sentynel> so the next question is, why is that code there in the first place
[15:45:39] <stilor> I have no idea, I didn't look into Amarok code until two days ago ;)
[15:45:49] <Sentynel> whatever it is it's been there since 2007
[15:48:05] <stilor> yeah, I found the commit but the message doesn't say anything about why nested event processing is needed
[15:51:15] <Sentynel> well, it doesn't seem to break anything as far as I can tell...
[15:51:29] <Sentynel> my suggestion would be to submit a review request for taking that loop out
[15:51:33] <Sentynel> and see if anybody else has any ideas why it's there
[15:54:01] <Sentynel> the other thing that works is changing QEventLoop::AllEvents to QEventLoop::ExcludeUserInputEvents
[15:54:22] <Sentynel> which stops the crash and should theoretically still let it process whatever events it was trying to process
[15:54:51] <Sentynel> but I'd rather get rid of that code block entirely if it's not doing anything useful


This addresses bug 295275.
    https://bugs.kde.org/show_bug.cgi?id=295275


Diffs
-----

  src/AmarokMimeData.cpp 226b0fa 

Diff: http://git.reviewboard.kde.org/r/104321/diff/


Testing
-------


Thanks,

Alexey Neyman

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120317/3047f7cb/attachment.html>