Review Request: Implemented Bug 214721 - Enable bookmark marker to be moved

[Jasneet Bhatti]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104307/
-----------------------------------------------------------

(Updated March 17, 2012, 9:02 a.m.)


Review request for Amarok.


Description (updated)
-------

This patch implements https://bugs.kde.org/show_bug.cgi?id=214721 . The bookmark is movable within the slider. If it is dragged outside the range, it will revert to its previous valid location. The bookmark is activated( seek is called ) only when the bookmark's position hasn't changed.

In addition, also fixed a bug that deleted a different bookmark that shared the same name(possible by manual renaming), by appending the location of the bookmark even in case of manual renaming.


Diffs
-----

  src/amarokurls/BookmarkModel.cpp 9218088 
  src/amarokurls/AmarokUrl.h 6a1d67f 
  src/amarokurls/AmarokUrl.cpp 19ba210 
  src/amarokurls/BookmarkModel.h 73ae345 
  src/widgets/BookmarkTriangle.h 46e9118 
  src/widgets/BookmarkTriangle.cpp 4c59d42 
  src/widgets/SliderWidget.cpp 5e72e13 

Diff: http://git.reviewboard.kde.org/r/104307/diff/


Testing
-------

Tested it on ubuntu 11.04 with kubuntu-desktop. Works fine for me.


Thanks,

Jasneet Bhatti

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120317/53e73be6/attachment-0001.html>