Review Request: Load all tracks from XSPF using MetaProxy.

Bart Cerneels bart.cerneels at kde.org
Tue Mar 13 09:12:20 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104256/
-----------------------------------------------------------

(Updated March 13, 2012, 9:12 a.m.)


Review request for Amarok.


Description
-------

Load all tracks from XSPF using MetaProxy.

Added a worker that does the actual trackForUrl call and subscribes to
trackProviderAdded signal as needed.


This addresses bug 295199.
    https://bugs.kde.org/show_bug.cgi?id=295199


Diffs
-----

  src/CMakeLists.txt 4241e69 
  src/core-impl/collections/support/CollectionManager.cpp 37fe03a 
  src/core-impl/meta/proxy/MetaProxy.h d8329be 
  src/core-impl/meta/proxy/MetaProxy.cpp d1577a2 
  src/core-impl/meta/proxy/MetaProxyWorker.h PRE-CREATION 
  src/core-impl/meta/proxy/MetaProxyWorker.cpp PRE-CREATION 
  src/core-impl/meta/proxy/MetaProxy_p.h 792675d 
  src/core-impl/playlists/types/file/xspf/XSPFPlaylist.cpp 4cb49fb 

Diff: http://git.reviewboard.kde.org/r/104256/diff/


Testing
-------

Loaded XSPF attached to https://bugs.kde.org/show_bug.cgi?id=295199 

Could impact AmpacheService. Not checked yet.


Thanks,

Bart Cerneels

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120313/d6daa811/attachment-0001.html>


More information about the Amarok-devel mailing list