Review Request: Fix for bug 263693: The Delete Tracks dialog is misleading/ambiguous

[Matěj Laitl]

> On March 8, 2012, 1:14 p.m., Bart Cerneels wrote:
> > I feel you should still show the file path in the confirmation dialog. After all, you might have duplicates you want to remove and can't be sure which copy it is.

The latest version shows it in all cases. (or you talk about prettyUrl() vs. url()?)


- Matěj


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102236/#review11236
-----------------------------------------------------------


On March 7, 2012, 11:39 p.m., Ryan McCoskrie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102236/
> -----------------------------------------------------------
> 
> (Updated March 7, 2012, 11:39 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Fix for bug 263693. When the user is asked to confirm deleting a file from his/her music collection the prompt will use the songs meta-data in place of the path name if possible.
> 
> 
> This addresses bug 263693.
>     https://bugs.kde.org/show_bug.cgi?id=263693
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/support/CollectionLocationDelegateImpl.h 12b975f 
>   src/core-impl/collections/support/CollectionLocationDelegateImpl.cpp fb7c18f 
> 
> Diff: http://git.reviewboard.kde.org/r/102236/diff/
> 
> 
> Testing
> -------
> 
> Ran application and asked to delete several files from collection. Patch worked as expected.
> Deleted meta date from one track and asked to delete that also. Found that Meta::TrackPtr::prettyName()
> will return the file name of the track instead of an empty QString and that Meta::ArtistPtr::prettyName()
> returns 'Unknown Artist' in place of an empty QString. This will render the data checking needless under
> all known circumstances.
> 
> 
> Screenshots
> -----------
> 
> Uses meta-data instead of raw file path
>   http://git.reviewboard.kde.org/r/102236/s/220/
> 
> 
> Thanks,
> 
> Ryan McCoskrie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120308/42bd10a8/attachment.html>