Review Request: SoK - Unit Test : core/collections/QueryMaker
Matěj Laitl
matej at laitl.cz
Wed Jun 27 12:10:04 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105172/#review15195
-----------------------------------------------------------
Ship it!
Good work.
- Matěj Laitl
On June 27, 2012, 11:14 a.m., Jasneet Bhatti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105172/
> -----------------------------------------------------------
>
> (Updated June 27, 2012, 11:14 a.m.)
>
>
> Review request for Amarok, Matěj Laitl and Sven Krohlas.
>
>
> Description
> -------
>
> Implements unit test for the QueryMaker class in core/collections/QueryMaker
>
>
> Diffs
> -----
>
> tests/core/collections/CMakeLists.txt b01b655
> tests/core/collections/TestQueryMaker.h PRE-CREATION
> tests/core/collections/TestQueryMaker.cpp PRE-CREATION
> tests/mocks/MockQueryMaker.h PRE-CREATION
> tests/mocks/MockQueryMaker.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/105172/diff/
>
>
> Testing
> -------
>
> Test builds and runs fine
>
>
> Thanks,
>
> Jasneet Bhatti
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120627/2979726c/attachment.html>
More information about the Amarok-devel
mailing list