Review Request: SoK - Unit Test : core/collections/QueryMaker

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105172/#review15192
-----------------------------------------------------------


The test is okay, but please fix compiler warning (AFAICS there will be ones) and minor glitch.


tests/mocks/MockQueryMaker.h
<http://git.reviewboard.kde.org/r/105172/#comment11893>

    Doesn't compiler emit unused variable warning? I meant to use addReturnValue( qint64 ) in my previous comment. (notice the argument has type but no name)



tests/mocks/MockQueryMaker.cpp
<http://git.reviewboard.kde.org/r/105172/#comment11894>

    Nicpicky: now including this shouldn't be needed.


- Matěj Laitl


On June 26, 2012, 8:05 p.m., Jasneet Bhatti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105172/
> -----------------------------------------------------------
> 
> (Updated June 26, 2012, 8:05 p.m.)
> 
> 
> Review request for Amarok, Matěj Laitl and Sven Krohlas.
> 
> 
> Description
> -------
> 
> Implements unit test for the QueryMaker class in core/collections/QueryMaker
> 
> 
> Diffs
> -----
> 
>   tests/core/collections/CMakeLists.txt b01b655 
>   tests/core/collections/TestQueryMaker.h PRE-CREATION 
>   tests/core/collections/TestQueryMaker.cpp PRE-CREATION 
>   tests/mocks/MockQueryMaker.h PRE-CREATION 
>   tests/mocks/MockQueryMaker.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105172/diff/
> 
> 
> Testing
> -------
> 
> Test builds and runs fine
> 
> 
> Thanks,
> 
> Jasneet Bhatti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120627/dd9d983e/attachment-0001.html>