Review Request: SoK - Unit Test : core/collections/QueryMaker

[Jasneet Bhatti]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105172/
-----------------------------------------------------------

(Updated June 26, 2012, 7:59 p.m.)


Review request for Amarok, Matěj Laitl and Sven Krohlas.


Changes
-------

Moved mock class into the tests/mocks directory.
Altered name of function, code style, and removed dynamic cast and Q_UNUSED macros.


Description
-------

Implements unit test for the QueryMaker class in core/collections/QueryMaker


Diffs (updated)
-----

  tests/core/collections/CMakeLists.txt b01b655 
  tests/core/collections/TestQueryMaker.h PRE-CREATION 
  tests/core/collections/TestQueryMaker.cpp PRE-CREATION 
  tests/mocks/MockQueryMaker.h PRE-CREATION 
  tests/mocks/MockQueryMaker.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/105172/diff/


Testing
-------

Test builds and runs fine


Thanks,

Jasneet Bhatti

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120626/ce98bc1c/attachment.html>