Review Request: Bug 292081 - JJ: Label about info at opendesktop.org is truncated

Maarten De Meyer de.meyer.maarten at gmail.com
Sat Jun 23 13:20:06 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104464/#review15041
-----------------------------------------------------------


Can you add a screenshot of what it looks like wrapped? I think it might look better if you just use a tooltip.
(I am no amarok dev but this should give you a little bump so they see your patch)

- Maarten De Meyer


On April 2, 2012, 3:15 p.m., Lachlan Dufton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104464/
> -----------------------------------------------------------
> 
> (Updated April 2, 2012, 3:15 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Fix for bug #292081
> 
> AnimatedBarWidget is modified to wrap text when widget is too narrow.
> 
> 
> This addresses bug 292081.
>     https://bugs.kde.org/show_bug.cgi?id=292081
> 
> 
> Diffs
> -----
> 
>   src/aboutdialog/AnimatedBarWidget.h 8ec32ad 
>   src/aboutdialog/AnimatedBarWidget.cpp f40dd6d 
> 
> Diff: http://git.reviewboard.kde.org/r/104464/diff/
> 
> 
> Testing
> -------
> 
> Tested changed widget correctly wraps text when About dialog is resized.
> 
> 
> Thanks,
> 
> Lachlan Dufton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120623/a33ab9ac/attachment-0001.html>


More information about the Amarok-devel mailing list