Review Request: SoK Unit test : core/collections/Collection

Jasneet Bhatti jazneetbhatti at gmail.com
Fri Jun 22 11:07:42 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105166/
-----------------------------------------------------------

(Updated June 22, 2012, 11:07 a.m.)


Review request for Amarok and Sven Krohlas.


Changes
-------

Minor changes to coding style and comments


Description
-------

This patch implements a unit test for core/collections/Collection

There are abstract classes to be tested as well, which can only be done when subclasses define the pure virtual functions. So tests for those will be done along with the subclasses.


Diffs (updated)
-----

  tests/core/collections/CMakeLists.txt 2efd1fe 
  tests/core/collections/TestCollection.h PRE-CREATION 
  tests/core/collections/TestCollection.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/105166/diff/


Testing
-------

Test passes on my repository


Thanks,

Jasneet Bhatti

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120622/bd7b0bf7/attachment.html>


More information about the Amarok-devel mailing list