Review Request: SoK Unit test : core/collections/Collection

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105166/#review14968
-----------------------------------------------------------

Ship it!


Well done, I have some really smallish things.


tests/core/collections/TestCollection.h
<http://git.reviewboard.kde.org/r/105166/#comment11769>

    Not really needed to test such dumb method, but why not, feel free to keep it.



tests/core/collections/TestCollection.cpp
<http://git.reviewboard.kde.org/r/105166/#comment11768>

    Coding style says to use 0 instead of null, and there is KSharedPtr::isNull() which is the preffered one.


- Matěj Laitl


On June 21, 2012, 9:41 p.m., Jasneet Bhatti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105166/
> -----------------------------------------------------------
> 
> (Updated June 21, 2012, 9:41 p.m.)
> 
> 
> Review request for Amarok and Sven Krohlas.
> 
> 
> Description
> -------
> 
> This patch implements a unit test for core/collections/Collection
> 
> There are abstract classes to be tested as well, which can only be done when subclasses define the pure virtual functions. So tests for those will be done along with the subclasses.
> 
> 
> Diffs
> -----
> 
>   tests/core/collections/CMakeLists.txt 2efd1fe 
>   tests/core/collections/TestCollection.h PRE-CREATION 
>   tests/core/collections/TestCollection.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105166/diff/
> 
> 
> Testing
> -------
> 
> Test passes on my repository
> 
> 
> Thanks,
> 
> Jasneet Bhatti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120621/c5b6025b/attachment.html>