Review Request: SoK Unit test : core/collections/Collection

[Jasneet Bhatti]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105166/
-----------------------------------------------------------

(Updated June 21, 2012, 1:38 p.m.)


Review request for Amarok and Sven Krohlas.


Changes
-------

Rewrote the entire test.

TrackProvider has trivial functions that have been tested directly

CollectionBase has been tested using a mock subclass, similar to the way I did with class MetaCapability of core/meta/Meta

Collection is an abstract class, so tested the non pure virtual functions using a mock subclass


Description
-------

This patch implements a unit test for core/collections/Collection

There are abstract classes to be tested as well, which can only be done when subclasses define the pure virtual functions. So tests for those will be done along with the subclasses.


Diffs (updated)
-----

  tests/core/collections/CMakeLists.txt 2efd1fe 
  tests/core/collections/TestCollection.h PRE-CREATION 
  tests/core/collections/TestCollection.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/105166/diff/


Testing
-------

Test passes on my repository


Thanks,

Jasneet Bhatti

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120621/e8ec27b8/attachment.html>