[amarok] /: partly fix TestPlaylistFileProvider

Matěj Laitl matej at laitl.cz
Wed Jun 20 14:29:36 UTC 2012


On 20. 6. 2012 Sven Krohlas wrote:
> Git commit 1714ad3ca1c0cb368d64c5f2a35778ea21fee859 by Sven Krohlas.
> Committed on 20/06/2012 at 14:54.
> Pushed by krohlas into branch 'master'.
> 
> partly fix TestPlaylistFileProvider
> 
> This one was quite broken. It no longer crashes but still fails.
> 
> It seems as if PlaylistFileProvider::save()
> * returns NULL if attempting to save an m3u playlist (that was the cause of
> the crash)
> * adds an additional.xspf to the given file name, if it ends
> with .xspf
> * doesn't save a .pls file to disc

Good. I think you can add QEXPECT_FAIL() [1] to tests that are correct but 
currently fail because the actual implementation is buggy.

[1] http://qt-project.org/doc/qt-4.8/qtest.html#QEXPECT_FAIL

	Matěj


More information about the Amarok-devel mailing list