Review Request: SoK - Unit test : core/capabilities/ActionsCapability

[Sven Krohlas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105144/#review14898
-----------------------------------------------------------

Ship it!


Apart from that single "issue" it looks fine to me. Change that and ship it. :)

Compiles, links and runs fine here.


tests/core/capabilities/CMakeLists.txt
<http://git.reviewboard.kde.org/r/105144/#comment11694>

    ${KDE4_KDEUI_LIBS} is not required, ${QT_QTGUI_LIBRARY} is enough:
    
    target_link_libraries( testactionscapability ${KDE4_KDECORE_LIBS} ${QT_QTGUI_LIBRARY} ${QT_QTTEST_LIBRARY} amarokcore amaroklib )


- Sven Krohlas


On June 18, 2012, 8:15 p.m., Jasneet Bhatti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105144/
> -----------------------------------------------------------
> 
> (Updated June 18, 2012, 8:15 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> This is a patch implementing unit testing of core/capabilities/ActionsCapability
> 
> 
> Diffs
> -----
> 
>   src/core/capabilities/ActionsCapability.h 08de31d 
>   tests/core/CMakeLists.txt c66d3be 
>   tests/core/capabilities/CMakeLists.txt e69de29 
>   tests/core/capabilities/TestActionsCapability.h e69de29 
>   tests/core/capabilities/TestActionsCapability.cpp e69de29 
> 
> Diff: http://git.reviewboard.kde.org/r/105144/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jasneet Bhatti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120619/60b675a2/attachment-0001.html>