Review Request: SoK - Unit Test : core/meta/Meta (MetaCapability)

[Matěj Laitl]

> On June 19, 2012, 1:21 p.m., Sven Krohlas wrote:
> > You need to add ${QT_QTGUI_LIBRARY} to the target_link_libraries: target_link_libraries( testmetacapability ${KDE4_KDECORE_LIBS} ${QT_QTTEST_LIBRARY} ${QT_QTGUI_LIBRARY} amarokcore )
> > 
> > to avoid:
> > 
> > /usr/lib/gcc/i586-suse-linux/4.6/../../../../i586-suse-linux/bin/ld: CMakeFiles/testmetacapability.dir/TestMetaCapability.o: undefined reference to symbol 'QAction::QAction(QObject*)'
> > /usr/lib/gcc/i586-suse-linux/4.6/../../../../i586-suse-linux/bin/ld: note: 'QAction::QAction(QObject*)' is defined in DSO /usr/lib/libQtGui.so.4 so try adding it to the linker command line
> > /usr/lib/libQtGui.so.4: could not read symbols: Invalid operation
> > collect2: ld returned 1 exit status
> > make[2]: *** [tests/testmetacapability] Fehler 1
> > make[1]: *** [tests/core/meta/CMakeFiles/testmetacapability.dir/all] Fehler 2
> > 
> > And then ship it. :)
> 
> Matěj Laitl wrote:
>     Oh yes, QAction dependency was added atop of my exaple patch I sent. Jasneet, did you really test your patch befere posting it here? You would have faced this error if you did.
> 
> Jasneet Bhatti wrote:
>     I tested it twice and it was building just fine. And it baffled me too that Sven faced this error and not me until he said it was probably because cmake sometimes doesn't detect changes to cmake files and the older version had several more link targets including this one.

Ah, okay.


- Matěj


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105291/#review14883
-----------------------------------------------------------


On June 19, 2012, 2:02 p.m., Jasneet Bhatti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105291/
> -----------------------------------------------------------
> 
> (Updated June 19, 2012, 2:02 p.m.)
> 
> 
> Review request for Amarok, Bart Cerneels, Matěj Laitl, and Sven Krohlas.
> 
> 
> Description
> -------
> 
> Unit Test for class MetaCapability of core/meta/Meta
> 
> 
> Diffs
> -----
> 
>   tests/core/meta/CMakeLists.txt 0e85d83 
>   tests/core/meta/TestMetaCapability.h PRE-CREATION 
>   tests/core/meta/TestMetaCapability.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105291/diff/
> 
> 
> Testing
> -------
> 
> Unit Test builds and runs as desired
> 
> 
> Thanks,
> 
> Jasneet Bhatti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120619/856083e2/attachment.html>