Review Request: GSoC report: Integrate Spotify into Amarok #4 (squashed commits, recent on top)

Zhengliang Feng odayfans at gmail.com
Sun Jun 17 23:28:13 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105285/
-----------------------------------------------------------

Review request for Amarok.


Description
-------

Things I've done this week:
* Added a new playlist provider SpotifyPlaylistProvider
* Added playlist class SpotifyPlaylist
* Clear all extra whitespaces
* Figured out how Collection, QueryMaker and Playlist worked

Things need to be done next week:
* Clean ScriptResolver's interfaces, move all query related interfaces into Query class
* Replace Controller class with ScriptResolver
* Test SpotifyCollection
* Finish playlist and playlist provider


Diffs
-----

  src/core-impl/collections/CMakeLists.txt c78b9202ece71b51189c4e47d85acfa4a74ef8d6 
  src/core-impl/collections/spotifycollection/CMakeLists.txt PRE-CREATION 
  src/core-impl/collections/spotifycollection/SpotifyCollection.h PRE-CREATION 
  src/core-impl/collections/spotifycollection/SpotifyMeta.h PRE-CREATION 
  src/core-impl/collections/spotifycollection/SpotifyMeta.cpp PRE-CREATION 
  src/core-impl/collections/spotifycollection/SpotifyPlaylist.h PRE-CREATION 
  src/core-impl/collections/spotifycollection/SpotifyPlaylist.cpp PRE-CREATION 
  src/core-impl/collections/spotifycollection/SpotifyPlaylistProvider.h PRE-CREATION 
  src/core-impl/collections/spotifycollection/SpotifyPlaylistProvider.cpp PRE-CREATION 
  src/core-impl/collections/spotifycollection/SpotifyQueryMaker.h PRE-CREATION 
  src/core-impl/collections/spotifycollection/SpotifyQueryMaker.cpp PRE-CREATION 
  src/core-impl/collections/spotifycollection/support/Controller.h PRE-CREATION 
  src/core-impl/collections/spotifycollection/support/Controller.cpp PRE-CREATION 
  src/core-impl/collections/spotifycollection/support/QMFunctionTypes.h PRE-CREATION 
  src/core-impl/collections/spotifycollection/support/Query.h PRE-CREATION 
  src/core-impl/collections/spotifycollection/support/Query.cpp PRE-CREATION 
  src/core-impl/collections/spotifycollection/support/ScriptResolver.h PRE-CREATION 
  src/core-impl/collections/spotifycollection/support/ScriptResolver.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/105285/diff/


Testing
-------

No test done this week. 


Thanks,

Zhengliang Feng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120617/e216182a/attachment.html>


More information about the Amarok-devel mailing list