Review Request: liblastfm1 port

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105276/
-----------------------------------------------------------

Review request for Amarok.


Description
-------

port to liblastfm1, mind that this is slightly api incompatible with liblastfm0, and retaining ifdef compat does not seem worthwhile given the fact that latter uses exceptions and former does not


Diffs
-----

  src/services/ampache/LastfmInfoParser.cpp 50cb529516ce1358785fa04824cd32642a526495 
  src/services/lastfm/LastFmService.cpp a14d989b3fac81e545df095adee36580b052fea7 
  src/services/lastfm/LastFmServiceCollection.cpp 22f49ec0fe8e9f917f8a26f9d546ad147ad04e5b 
  src/services/lastfm/LastFmServiceSettings.cpp 2eff71e51dc30605b4d395323a01e24b8fa25d1e 
  src/services/lastfm/LastFmTreeModel.h ac171a57a36ec6bb5443035b11bea77e4ae94720 
  src/services/lastfm/LastFmTreeModel.cpp 2d94d67c5fe10bfc1abba3dd9848fd1177daa518 
  src/services/lastfm/ScrobblerAdapter.h 67ed73b291cef61ee37b0ddae28ba1eadfd6304d 
  src/services/lastfm/biases/LastFmBias.cpp b011b3299f98d851109d3d9ba52e6fd09855dcff 
  src/services/lastfm/biases/WeeklyTopBias.cpp df6dd6681f05d95a0e281d6e82224de2bbf001e6 
  src/services/lastfm/meta/LastFmMeta.h f7b93c14c92c0bebf99d165656a0e34f8b991cc0 
  src/services/lastfm/meta/LastFmMeta.cpp d8f52845cb801d8ae940bc1bca77c7281ef18379 
  src/services/lastfm/meta/LastFmMeta_p.h c2d88ac79a4dd0fe59b9f889baf72c879833f0d3 
  src/services/lastfm/meta/MultiPlayableCapabilityImpl_p.h 1c464cc2635c7d614eab48ca5e4e156c67870f04 
  src/context/engines/upcomingevents/UpcomingEventsEngine.cpp 4ae73d892cef3d4a41662f7ed15849ae773c16e3 
  src/core/support/Amarok.h c9852154dee74fb372bae435fdeefa92003d41b1 
  CMakeLists.txt 0d146c58bd382b4d4f379ebedddf1630d73db369 
  cmake/modules/FindLibLastFm.cmake 1d863b08489e27054a049e35d2d94667646db1f7 
  src/LastfmReadLabelCapability.cpp 385e6b9c065009b330e116e3d748b82c24f14e8d 

Diff: http://git.reviewboard.kde.org/r/105276/diff/


Testing
-------

[~] login test in settings (for some reason the service does not pick up changes there until restart, which seems actually architectural as the KCM does not trigger reinitialization of the service)
[+] streaming
  [+] love
  [+] ban
  [+] next
[+] friends/neighbors
[+] upcoming events plasmoid
[+] related artists plasmoid


Thanks,

Harald Sitter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120616/b29c1ba3/attachment.html>